Long integer literals in hex fail to get parsed with a runtime exception

JsLexer recognizes decimals, octals and hexadecimal numbers, however, java bignumbers parse only decimals.  This change recognizes large hex and octal numbers and parses them accordingly.

@4426

[felix8a, 2011-03-29 00:09:24]

http://codereview.appspot.com/4277080/diff/1/src/com/google/caja/parser/js/Pa...
File src/com/google/caja/parser/js/Parser.java (right):

http://codereview.appspot.com/4277080/diff/1/src/com/google/caja/parser/js/Pa...
src/com/google/caja/parser/js/Parser.java:982: private static BigInteger
MAX_REPRESENTABLE = BigInteger.valueOf(1L << 51 -1);
- has higher precedence than <<, need parens around (1L << 51)

http://codereview.appspot.com/4277080/diff/1/src/com/google/caja/parser/js/Pa...
src/com/google/caja/parser/js/Parser.java:983: private static BigInteger
MIN_REPRESENTABLE = MAX_REPRESENTABLE.negate();
should be
  MAX_REPRESENTABLE.negate().subtract(new BigInteger(1))
might be clearer to say
  BigInteger.valueOf(-(1L << 51));

[Jasvir, 2011-03-29 00:16:02]

snapshot

http://codereview.appspot.com/4277080/diff/1/src/com/google/caja/parser/js/Pa...
File src/com/google/caja/parser/js/Parser.java (right):

http://codereview.appspot.com/4277080/diff/1/src/com/google/caja/parser/js/Pa...
src/com/google/caja/parser/js/Parser.java:982: private static BigInteger
MAX_REPRESENTABLE = BigInteger.valueOf(1L << 51 -1);
On 2011/03/29 00:09:24, felix8a wrote:
> - has higher precedence than <<, need parens around (1L << 51)

Done.

http://codereview.appspot.com/4277080/diff/1/src/com/google/caja/parser/js/Pa...
src/com/google/caja/parser/js/Parser.java:983: private static BigInteger
MIN_REPRESENTABLE = MAX_REPRESENTABLE.negate();
On 2011/03/29 00:09:24, felix8a wrote:
> should be
>   MAX_REPRESENTABLE.negate().subtract(new BigInteger(1))
> might be clearer to say
>   BigInteger.valueOf(-(1L << 51));

Done.

[felix8a, 2011-03-29 00:17:36]

lgtm