Issue 4277070: code review 4277070: 5l/6l/8l: undo spadj cleanup at ARET for following inst...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4277070: code review 4277070: 5l/6l/8l: undo spadj cleanup at ARET for following inst... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by lvd

Modified:
13 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

5l/6l/8l: undo spadj cleanup at ARET for following instructions in the same stackframe. 5l was already correct, clarified comment and added diags for unmaintained code.

Patch Set 2 : diff -r 741cebe073f1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 741cebe073f1 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 2e9c301b1dc0 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -14 lines)			Patch
M	src/cmd/5l/noop.c	View	1	6 chunks	+12 lines, -6 lines	0 comments	Download
M	src/cmd/6l/pass.c	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/cmd/8l/pass.c	View	1 2 3	1 chunk	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

lvd

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-03-23 16:23:10 UTC) #1

rsc

LGTM http://codereview.appspot.com/4277070/diff/4/src/cmd/6l/pass.c File src/cmd/6l/pass.c (right): http://codereview.appspot.com/4277070/diff/4/src/cmd/6l/pass.c#newcode677 src/cmd/6l/pass.c:677: // If there are instructions following either you ...

13 years, 11 months ago (2011-03-23 16:58:46 UTC) #2

lvd

13 years, 11 months ago (2011-03-23 22:11:36 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b5c246d30318 ***

5l/6l/8l: undo spadj cleanup at ARET for following instructions in the same
stackframe.

5l was already correct, clarified comment and added diags for unmaintained code.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4277070

Expand All Messages | Collapse All Messages