Issue 4277051: Add checkbutton to show content of sha field

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4277051: Add checkbutton to show content of sha field (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by nicoe

Modified:
15 years ago

Reviewers:
udono, ced

Visibility:
Public.

Patch Set 2 : use gettext and a more understandable tooltip #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	tryton/gui/window/view_form/view/form_gtk/char.py	View	1	2 chunks	+23 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

udono

lgtm, untested. http://codereview.appspot.com/4277051/diff/1/tryton/gui/window/view_form/view/form_gtk/char.py File tryton/gui/window/view_form/view/form_gtk/char.py (right): http://codereview.appspot.com/4277051/diff/1/tryton/gui/window/view_form/view/form_gtk/char.py#newcode58 tryton/gui/window/view_form/view/form_gtk/char.py:58: Tooltips().set_tip(self.visibility_checkbox, 'Show password') Better use generic "Show ...

15 years ago (2011-03-15 10:36:48 UTC) #2

ced

http://codereview.appspot.com/4277051/diff/1/tryton/gui/window/view_form/view/form_gtk/char.py File tryton/gui/window/view_form/view/form_gtk/char.py (right): http://codereview.appspot.com/4277051/diff/1/tryton/gui/window/view_form/view/form_gtk/char.py#newcode58 tryton/gui/window/view_form/view/form_gtk/char.py:58: Tooltips().set_tip(self.visibility_checkbox, 'Show password') Missing _() for translation

15 years ago (2011-03-15 14:29:55 UTC) #3

nicoe

15 years ago (2011-03-16 12:13:08 UTC) #4

LGTM

Expand All Messages | Collapse All Messages