Issue 4277050: Exposing option to mutate httprequest before sending out

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4277050: Exposing option to mutate httprequest before sending out

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by atulvasu

Modified:
15 years ago

Reviewers:
gagan.goku, cool-shindig-committers, dev

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -15 lines)			Patch
	M	java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java	View		4 chunks	+22 lines, -15 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gagan.goku

lgtm. Please send out to dev@ http://codereview.appspot.com/4277050/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java (right): http://codereview.appspot.com/4277050/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java#newcode164 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java:164: logger.log(Level.WARNING, "Triggered fetch ...

15 years ago (2011-03-14 13:06:42 UTC) #3

atulvasu

15 years ago (2011-03-14 13:10:19 UTC) #4

http://codereview.appspot.com/4277050/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java
(right):

http://codereview.appspot.com/4277050/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java:164:
logger.log(Level.WARNING, "Triggered fetch failed for " + request, e);
On 2011/03/14 13:06:42, gagan.goku wrote:
> please make sure that request.toString is readable, and not something useless.

It works nicely, it has entire url, host header, and remaining headers, and even
things like auth related stuff.

Expand All Messages | Collapse All Messages