Issue 4276057: code review 4276057: go/ast: merge CaseClause and TypeCaseClause

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4276057: code review 4276057: go/ast: merge CaseClause and TypeCaseClause (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by gri

Modified:
14 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/ast: merge CaseClause and TypeCaseClause (per rsc's suggestion)

Patch Set 1 #

Patch Set 2 : diff -r 8dc5f83d08cd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8dc5f83d08cd https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8dc5f83d08cd https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 8dc5f83d08cd https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -105 lines)			Patch
M	src/cmd/cgo/ast.go	View	1 2 3 4	1 chunk	+9 lines, -7 lines	0 comments	Download
M	src/cmd/gofix/fix.go	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/pkg/exp/eval/stmt.go	View	1	4 chunks	+5 lines, -8 lines	0 comments	Download
M	src/pkg/go/ast/ast.go	View	1 2 3 4	5 chunks	+8 lines, -24 lines	0 comments	Download
M	src/pkg/go/ast/walk.go	View	1	2 chunks	+1 line, -7 lines	0 comments	Download
M	src/pkg/go/parser/parser.go	View	1 2 3 4	4 chunks	+17 lines, -43 lines	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	1	2 chunks	+2 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-03-16 20:49:11 UTC) #1

gri

14 years ago (2011-03-16 21:26:06 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=031ec486a5f6 ***

go/ast: merge CaseClause and TypeCaseClause
(per rsc's suggestion)

R=rsc
CC=golang-dev
http://codereview.appspot.com/4276057

Expand All Messages | Collapse All Messages