Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(279)

Issue 4273074: downstem 64th and 128th flag touchup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by lemniskata.bernoulliego
Modified:
14 years, 10 months ago
Reviewers:
Janek Warchol, cpkc, carl.d.sorensen, Graham Percival (old account)
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

downstem 64th and 128th flag touchup 64th and 128th flags are made less trianglish (squeezed at the bottom), also the gap between flag and notehead is reduced. The flags look now more consistent with 16th and 32nd flags, as well as with upstem flags. downstem 16th and 32nd flags touchup 32nd downstem flag is made less 'bumpy' (curves on the right edge of the flag are less pronounced, to match 64th and 128th flags better). Also, 16th and 32nd flags are made more consistent. In particular, flares are corrected so now 32nd flag isn't suddenly thicker than 16th flag. shortening of downstem 8th flag This was discussed here: http://lists.gnu.org/archive/html/lilypond-devel/2011-03/msg00128.html Not many people gave their opinions; Carl prefers not changing this, but he doesn't feel strongly about it, Werner is not sure, but feels a bit more like shortening the flag, Mike agrees to make the change. My opinion is that it should be changed. including blot_diameter in calculating upstem flag lengths Doing so is needed in case of 32nd flag, because after changing 32nd stem length it touches staff line. In case of 64th and 128th this isn't really needed, but i added it for consistency's sake.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M mf/feta-flags.mf View 11 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 4
Janek Warchol
This changes correspond to http://lists.gnu.org/archive/html/lilypond-devel/2011-03/msg00399.html (You can see changes in fonts by running mf '\mode:=proof; ...
14 years, 10 months ago (2011-03-18 11:38:07 UTC) #1
Carl
LGTM. Carl
14 years, 10 months ago (2011-03-18 13:24:19 UTC) #2
cpkc_shaw.ca
On 11-03-18 05:38 AM, lemniskata.bernoullego@gmail.com wrote: > This changes correspond to > http://lists.gnu.org/archive/html/lilypond-devel/2011-03/msg00399.html > > ...
14 years, 10 months ago (2011-03-21 13:17:51 UTC) #3
Graham Percival (old account)
14 years, 10 months ago (2011-03-25 13:02:45 UTC) #4
Could you send me the final patch for pushing?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b