Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(294)

Issue 4271083: code review 4271083: go/printer, gofmt: rely on existing line breaks when fo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by gri
Modified:
11 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

go/printer, gofmt: rely on existing line breaks when formatting expression lists No impact on existing sources. Fixes issue 1632.

Patch Set 1 #

Patch Set 2 : diff -r 59d5bc43be1f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 59d5bc43be1f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 59d5bc43be1f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 59d5bc43be1f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M src/pkg/go/printer/nodes.go View 1 2 chunks +2 lines, -14 lines 0 comments Download
M src/pkg/go/printer/testdata/expressions.golden View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/go/printer/testdata/expressions.input View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/go/printer/testdata/expressions.raw View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 10 months ago (2011-03-29 01:35:04 UTC) #1
rsc
LGTM
11 years, 10 months ago (2011-03-29 01:48:14 UTC) #2
gri
11 years, 10 months ago (2011-03-29 01:48:58 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=94313f361fd2 ***

go/printer, gofmt: rely on existing line breaks when formatting expression lists

No impact on existing sources.

Fixes issue 1632.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4271083
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b