code review 4271080: io: fixes for Read with n > 0, os.EOF

io: fixes for Read with n > 0, os.EOF

[rh, 2011-03-26 22:10:40]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-04-02 00:16:18]

Thanks for taking care of this.

http://codereview.appspot.com/4271080/diff/7001/src/pkg/io/io.go
File src/pkg/io/io.go (right):

http://codereview.appspot.com/4271080/diff/7001/src/pkg/io/io.go#newcode192
src/pkg/io/io.go:192: switch {
This is confusing, because one case in the switch is a no-op
invented only so that default: can work.  Instead:


    if n >= min {
        err = nil
    } else if n > 0 {
        err = ErrUnexpectedEOF
    }

[rh, 2011-04-06 23:59:48]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rh, 2011-04-07 00:03:00]

PTAL.

On 2011/04/02 00:16:18, rsc wrote:
> Thanks for taking care of this.
> 
> http://codereview.appspot.com/4271080/diff/7001/src/pkg/io/io.go
> File src/pkg/io/io.go (right):
> 
> http://codereview.appspot.com/4271080/diff/7001/src/pkg/io/io.go#newcode192
> src/pkg/io/io.go:192: switch {
> This is confusing, because one case in the switch is a no-op
> invented only so that default: can work.  Instead:
> 
> 
>     if n >= min {
>         err = nil
>     } else if n > 0 {
>         err = ErrUnexpectedEOF
>     }

Done - I think...  It ended up feeling simpler to pull this out of the loop.  If
you do not like it this way, though, please let me know.

[rsc, 2011-04-08 17:45:34]

LGTM

[rsc, 2011-04-08 17:45:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=bafb61010a9d ***

io: fixes for Read with n > 0, os.EOF

R=rsc
CC=golang-dev
http://codereview.appspot.com/4271080

Committer: Russ Cox <rsc@golang.org>