Issue 4271048: code review 4271048: gofix: httpserver - rewrite rw.SetHeader to rw.Header.Set

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4271048: code review 4271048: gofix: httpserver - rewrite rw.SetHeader to rw.Header.Set (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by adg

Modified:
14 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gofix: httpserver - rewrite rw.SetHeader to rw.Header.Set

Patch Set 1 #

Patch Set 2 : diff -r 08c79ec9c4b9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7ec9cb1c9303 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	src/cmd/gofix/httpserver.go	View	1	2 chunks	+16 lines, -1 line	0 comments	Download
	M	src/cmd/gofix/httpserver_test.go	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-03-16 06:20:05 UTC) #1

rsc

You need to look for SetHeader("Key", "") and rewrite that as Header().Del. I'm so confused. ...

14 years ago (2011-03-16 15:05:04 UTC) #2

rsc

sel.Sel = ast.NewIdent("Set") if len(call.Args) >= 2 && isEmptyString(call.Args[1]) { sel.Sel = ast.NewIdent("Del") call.Args = ...

14 years ago (2011-03-16 15:35:21 UTC) #3

adg

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-03-16 22:07:44 UTC) #4

adg

14 years ago (2011-03-16 22:59:24 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=e791568f2691 ***

gofix: httpserver - rewrite rw.SetHeader to rw.Header.Set

R=rsc
CC=golang-dev
http://codereview.appspot.com/4271048

Expand All Messages | Collapse All Messages