Issue 4271044: Autocompletion on char fields (server side patch)

Issue 4271044: Autocompletion on char fields (server side patch) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by nicoe

Modified:
14 years, 10 months ago

Reviewers:
ced

Visibility:
Public.

Patch Set 2 : Updating the documentation #

Total comments: 8

Patch Set 3 : Use setdefault and fix autocomplete validation #

Patch Set 4 : Really use setdefault #

Total comments: 2

Patch Set 5 : Correctly check callability #

Patch Set 6 : removed completion attribute from xml validation files #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -21 lines)			Patch
M	doc/ref/models/fields.rst	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	trytond/ir/ui/form.rnc	View	1 2 3 4 5	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trytond/ir/ui/form.rng	View	1 2 3 4 5	1 chunk	+0 lines, -10 lines	0 comments	Download
M	trytond/model/fields/char.py	View	1 2	3 chunks	+17 lines, -1 line	0 comments	Download
M	trytond/model/model.py	View	1 2 3 4 5	2 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 13

Expand All Messages | Collapse All Messages

ced

http://codereview.appspot.com/4271044/diff/5001/trytond/model/fields/char.py File trytond/model/fields/char.py (right): http://codereview.appspot.com/4271044/diff/5001/trytond/model/fields/char.py#newcode6 trytond/model/fields/char.py:6: def autocomplete_validate(value): Shoud work also with None (or False) ...

14 years, 11 months ago (2011-03-15 11:03:49 UTC) #3

nicoe

14 years, 11 months ago (2011-03-18 16:45:50 UTC) #4

ced

http://codereview.appspot.com/4271044/diff/14001/trytond/model/model.py File trytond/model/model.py (right): http://codereview.appspot.com/4271044/diff/14001/trytond/model/model.py#newcode98 trytond/model/model.py:98: if callable(getattr(field, attribute, False)): The attribute is never callable ...

14 years, 11 months ago (2011-03-18 17:40:32 UTC) #7

ced

I think this patch must also remove the completion attribute on char widget

14 years, 10 months ago (2011-03-29 13:10:46 UTC) #11

LGTM + Changelog entry

Expand All Messages | Collapse All Messages