Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(849)

Issue 4271041: AccelServlet should pass through all headers including caching headers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by nikhilmadan23
Modified:
14 years, 11 months ago
Reviewers:
johnfargo, gagan.goku, dev-remailer
CC:
cool-shindig-committers_googlegroups.com, anupama.dutta, atulvasu
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

So far, the AccelServlet was designed to be only used for cache-control = public responses. As a result, for private responses, Cache-Control headers are modified. For example, Cache-Control=private,max-age=100 is transformed to Cache-Control=no-cache. Also, other Cache-Control derivatives(such as must-revalidate, no-store etc) were stripped. For public content with neither a max-age or an Expires header, it set the max-age to a default ttl of 300secs. This change simply passes through headers without modifying them. Note that this change is dependent on http://codereview.appspot.com/4260059/

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java View 1 chunk +1 line, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java View 2 chunks +64 lines, -0 lines 2 comments Download

Messages

Total messages: 5
nikhilmadan23
15 years ago (2011-03-10 14:38:16 UTC) #1
gagan.goku
LGTM++ Please send out to dev@ http://codereview.appspot.com/4271041/diff/1/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java File java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java (right): http://codereview.appspot.com/4271041/diff/1/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java#newcode360 java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java:360: .setHeader("Content-Type", "text/html") Set ...
15 years ago (2011-03-10 14:50:47 UTC) #2
nikhilmadan23
http://codereview.appspot.com/4271041/diff/1/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java File java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java (right): http://codereview.appspot.com/4271041/diff/1/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java#newcode360 java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java:360: .setHeader("Content-Type", "text/html") On 2011/03/10 14:50:47, gagan.goku wrote: > Set ...
15 years ago (2011-03-10 15:21:01 UTC) #3
anupama.dutta
LGTM.
15 years ago (2011-03-10 15:52:38 UTC) #4
gagan.goku
15 years ago (2011-03-10 19:20:55 UTC) #5
Build looks good.
Committed as r1080324.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b