Issue 427041: Fixing chained syntax parsing when params are at the end of configured path

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 427041: Fixing chained syntax parsing when params are at the end of configured path (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by johnfargo

Modified:
15 years, 10 months ago

Reviewers:
zhoresh, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

The DefaultProxyUriManagerTest implementation was also not using the process() method to verify parsing behavior, as it ought to have. Changing the logic surfaced the issue. Thanks to Ziv Horesh for taking notice.

Patch Set 1 #

Total comments: 1

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -29 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java	View		1 chunk	+12 lines, -8 lines	1 comment	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManagerTest.java	View		8 chunks	+31 lines, -21 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

zhoresh

LGTM http://codereview.appspot.com/427041/diff/1/3 File java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java (right): http://codereview.appspot.com/427041/diff/1/3#newcode185 java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java:185: int endIx = fullProxyUri.indexOf(endToken, startIx + startToken.length()); Maybe ...

15 years, 10 months ago (2010-03-11 02:25:17 UTC) #2

johnfargo

15 years, 10 months ago (2010-03-11 02:34:56 UTC) #3

Ha, seems reasonable. Added a bunch of commentary on this and committed.

On Wed, Mar 10, 2010 at 6:25 PM, <zhoresh@gmail.com> wrote:

> LGTM
>
>
> http://codereview.appspot.com/427041/diff/1/3
> File
>
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java
> (right):
>
> http://codereview.appspot.com/427041/diff/1/3#newcode185
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java:185:
> int endIx = fullProxyUri.indexOf(endToken, startIx +
> startToken.length());
> Maybe put some explanation/example here
> I will test you about this logic in a month ;-)
>
>
> http://codereview.appspot.com/427041/show
>

Expand All Messages | Collapse All Messages