Allow extensions to the common container by allowing other features to provide their own namespace

At the moment the common container cannot be extended by adding a new namespace and still have access to the container object. The only reasonable way to extend the common container at this moment it to add new methods by calling .prototype or by subclassing it. Another useful extension would be to allow features to add their own namespace to the common container and add new methods under that common container. However those methods may still want to reference other methods inside the common container so they need to be able to access the common container object itself.

[rbaxter85, 2011-03-09 02:18:15]

Updated patch with suggested changes

[mhermanto, 2011-03-09 07:16:26]

It looks a little odd:
1) to see internal instance variables directly referred by a utility/helper
class.
2) mixins_ used outside of the shindig.container.Container scope.

Suggesting a simple change to (statically) add addMixin() on
shindig.container.Container, like below --

shindig.container.Container.addMixin = function(namespace, func){
  shindig.container.Container.prototype.mixins_[namespace] = func;
}

With this, we also get a shorter function name than addContainerMixin(),
because it is clear it is acting on the "container".

Please keep spaces consistent to 2 spaces, not tabs.

Sorry for chiming in late.


On Tue, Mar 8, 2011 at 6:18 PM, <rbaxter85@gmail.com> wrote:

> Updated patch with suggested changes
>
>
> http://codereview.appspot.com/4260049/
>

[rbaxter85, 2011-03-09 20:22:56]

Updated patch with Mike's suggestion

[mhermanto, 2011-03-09 20:39:11]

LGTM, submit away. :)

Nit, I still see indentation as more than 2 spaces (perhaps, it's just
codereview).

On Wed, Mar 9, 2011 at 12:22 PM, <rbaxter85@gmail.com> wrote:

> Updated patch with Mike's suggestion
>
>
> http://codereview.appspot.com/4260049/
>

[mhermanto, 2011-03-09 21:11:56]

Committed -- http://svn.apache.org/viewvc?rev=1079995&view=rev. Thanks.

On Wed, Mar 9, 2011 at 12:39 PM, Michael Hermanto <mhermanto@gmail.com>wrote:

> LGTM, submit away. :)
>
> Nit, I still see indentation as more than 2 spaces (perhaps, it's just
> codereview).
>
>
> On Wed, Mar 9, 2011 at 12:22 PM, <rbaxter85@gmail.com> wrote:
>
>> Updated patch with Mike's suggestion
>>
>>
>> http://codereview.appspot.com/4260049/
>>
>
>

[rjbaxter_us.ibm.com, 2011-03-09 21:26:17]

Thanks Mike!

-Ryan

Email: rjbaxter@us.ibm.com
Phone: 978-899-3041
developerWorks Profile



From:   Michael Hermanto <mhermanto@gmail.com>
To:     rbaxter85@gmail.com, mhermanto@gmail.com, dev@shindig.apache.org, 
dev-remailer@shindig.apache.org, fargo@google.com, 
reply@codereview.appspotmail.com, 
Date:   03/09/2011 04:14 PM
Subject:        Re: Allow extensions to the common container by allowing 
other features to provide their own namespace (issue4260049)



Committed -- http://svn.apache.org/viewvc?rev=1079995&view=rev. Thanks.

On Wed, Mar 9, 2011 at 12:39 PM, Michael Hermanto 
<mhermanto@gmail.com>wrote:

> LGTM, submit away. :)
>
> Nit, I still see indentation as more than 2 spaces (perhaps, it's just
> codereview).
>
>
> On Wed, Mar 9, 2011 at 12:22 PM, <rbaxter85@gmail.com> wrote:
>
>> Updated patch with Mike's suggestion
>>
>>
>> http://codereview.appspot.com/4260049/
>>
>
>