Issue 4260042: code review 4260042: http: initialize request Header for the transport

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4260042: code review 4260042: http: initialize request Header for the transport (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by bradfitz

Modified:
14 years ago

Reviewers:

CC:
rsc, r, bradfitzgoog, golang-dev

Visibility:
Public.

Description

http: initialize request Header for the transport Fixes issue 1558

Patch Set 2 : diff -r 117785e448a6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 117785e448a6 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 117785e448a6 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 117785e448a6 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	src/pkg/http/client.go	View	1 2 3	2 chunks	+11 lines, -0 lines	0 comments	Download
	M	src/pkg/http/client_test.go	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-03-02 17:22:00 UTC) #1

LGTM http://codereview.appspot.com/4260042/diff/4003/src/pkg/http/client.go File src/pkg/http/client.go (right): http://codereview.appspot.com/4260042/diff/4003/src/pkg/http/client.go#newcode112 src/pkg/http/client.go:112: if req.Header == nil { might be worth ...

14 years ago (2011-03-02 17:24:23 UTC) #2

bradfitz

Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.

14 years ago (2011-03-02 17:41:51 UTC) #3

bradfitzgoog

PTAL I added some docs on ClientTransport as well. On Wed, Mar 2, 2011 at ...

14 years ago (2011-03-02 17:42:13 UTC) #4

bradfitz

14 years ago (2011-03-02 18:22:04 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=06b4aa28105f ***

http: initialize request Header for the transport

Fixes issue 1558

R=rsc, r, bradfitzwork
CC=golang-dev
http://codereview.appspot.com/4260042

Expand All Messages | Collapse All Messages