Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(161)

Issue 4259047: code review 4259047: image: add a decoding test for common file formats. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by nigeltao
Modified:
14 years ago
Reviewers:
CC:
r, nigeltao_gnome, golang-dev
Visibility:
Public.

Description

image: add a decoding test for common file formats. The test image was converted from doc/video-001.png using the convert command line tool (ImageMagick 6.5.7-8) at -quality 100.

Patch Set 1 #

Patch Set 2 : diff -r 673e2876186d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 673e2876186d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d5e4e4ff7c8e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -1 line) Patch
M src/pkg/Makefile View 1 1 chunk +0 lines, -1 line 0 comments Download
A src/pkg/image/decode_test.go View 1 1 chunk +89 lines, -0 lines 0 comments Download
A src/pkg/image/testdata/video-001.bmp View 1 Binary file 0 comments Download
A src/pkg/image/testdata/video-001.gif View 1 Binary file 0 comments Download
A src/pkg/image/testdata/video-001.jpeg View 1 Binary file 0 comments Download
A src/pkg/image/testdata/video-001.png View 1 Binary file 0 comments Download
A src/pkg/image/testdata/video-001.tiff View 1 Binary file 0 comments Download

Messages

Total messages: 4
nigeltao
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years ago (2011-03-02 22:08:36 UTC) #1
nigeltao_gnome
On 3 March 2011 09:08, <nigeltao@golang.org> wrote: > Description: > image: add a decoding test ...
14 years ago (2011-03-02 22:14:17 UTC) #2
r
LGTM
14 years ago (2011-03-02 22:21:49 UTC) #3
nigeltao
14 years ago (2011-03-03 09:36:08 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=44f9c2300d17 ***

image: add a decoding test for common file formats.

The test image was converted from doc/video-001.png using the
convert command line tool (ImageMagick 6.5.7-8) at -quality 100.

R=r, nigeltao_gnome
CC=golang-dev
http://codereview.appspot.com/4259047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b