Issue 4257044: Bug Fix - Add Pragma and Cache-Control header only if not null in AbstractHttpCache

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4257044: Bug Fix - Add Pragma and Cache-Control header only if not null in AbstractHttpCache (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by nikhilmadan23

Modified:
15 years ago

Reviewers:
johnfargo, gagan.goku, dev-remailer

CC:
cool-shindig-committers_googlegroups.com, satya3656, anupama.dutta

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

We should copy Pragma and Cache-Control headers in buildStrictNoCacheHttpResponse only if these have non-null values. This causes a bug in google web servers.

Patch Set 2 : Addressing comments #

Patch Set 5 : Addressing comments #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java	View	1 2 3 4	1 chunk	+14 lines, -2 lines	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

anupama.dutta

http://codereview.appspot.com/4257044/diff/9001/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java (right): http://codereview.appspot.com/4257044/diff/9001/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java#newcode106 java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java:106: private void copyHeaderIfPresent(String header, HttpResponse response, HttpResponseBuilder builder) { ...

15 years ago (2011-03-01 05:31:02 UTC) #3

johnfargo

LGTM++ On 2011/03/01 19:50:40, nikhilmadan23 wrote: > Addressing comments

15 years ago (2011-03-02 01:14:00 UTC) #5

gagan.goku

Mention in the cl description what bug you are seeing. On Wed, Mar 2, 2011 ...

15 years ago (2011-03-02 02:01:56 UTC) #6

Build looks good.
Committed as r1076086.

Expand All Messages | Collapse All Messages