Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(444)

Issue 4256057: code review 4256057: io/ioutil: use filepath.Join, handle trailing / in $TMPDIR (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by rsc
Modified:
13 years, 4 months ago
Reviewers:
CC:
niemeyer, golang-dev
Visibility:
Public.

Description

io/ioutil: use filepath.Join, handle trailing / in $TMPDIR

Patch Set 1 #

Patch Set 2 : diff -r 9fa1ce8c4404 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7c7d23f8ddbc https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0789311c2e60 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/pkg/io/ioutil/tempfile_test.go View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello niemeyer (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-03-06 23:06:20 UTC) #1
niemeyer
Looks good, thanks.
13 years, 4 months ago (2011-03-07 00:05:39 UTC) #2
rsc
13 years, 4 months ago (2011-03-07 02:52:42 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=14e2652750a0 ***

io/ioutil: use filepath.Join, handle trailing / in $TMPDIR

R=niemeyer
CC=golang-dev
http://codereview.appspot.com/4256057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b