code review 4253052: os, syscall: add ProcAttributes type. Change StartProce...

src/pkg/debug/proc/proc_linux.go

 // Copyright 2009 The Go Authors.  All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package proc
 
 // TODO(rsc): Imports here after to be in proc.go too in order
 // for deps.bash to get the right answer.
 import (
         "container/vector"
@@ skipping 1261 matching lines @@
         if err != nil {
                 p.Detach()
                 // TODO(austin) Detach stopped the monitor already
                 //p.stopMonitor(err);
                 return nil, err
         }
 
         return p, nil
 }
 
-// ForkExec forks the current process and execs argv0, stopping the
-// new process after the exec syscall.  See os.ForkExec for additional
+// StartProcess forks the current process and execs argv0, stopping the
+// new process after the exec syscall.  See os.StartProcess for additional
 // details.
-func ForkExec(argv0 string, argv []string, envv []string, dir string, fd []*os.File) (Process, os.Error) {
+func StartProcess(argv0 string, argv []string, attr *os.ProcAttr) (Process, os.Error) {
+        sysattr := &syscall.ProcAttr{
+                Dir:    attr.Dir,
+                Env:    attr.Env,
+                Ptrace: true,
+        }
         p := newProcess(-1)
 
         // Create array of integer (system) fds.
-        intfd := make([]int, len(fd))
-        for i, f := range fd {
+        intfd := make([]int, len(attr.Files))
+        for i, f := range attr.Files {
                 if f == nil {
                         intfd[i] = -1
                 } else {
                         intfd[i] = f.Fd()
                 }
         }
+        sysattr.Files = intfd
 
         // Fork from the monitor thread so we get the right tracer pid.
         err := p.do(func() os.Error {
-                pid, errno := syscall.PtraceForkExec(argv0, argv, envv, dir, intfd)
+                pid, _, errno := syscall.StartProcess(argv0, argv, sysattr)
                 if errno != 0 {
                         return &os.PathError{"fork/exec", argv0, os.Errno(errno)}
                 }
                 p.pid = pid
 
                 // The process will raise SIGTRAP when it reaches execve.
                 _, err := p.newThread(pid, syscall.SIGTRAP, false)
                 return err
         })
         if err != nil {
                 p.stopMonitor(err)
                 return nil, err
         }
 
         return p, nil
 }