Issue 4252069: Support caja santization for GadgetHandler metadata

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4252069: Support caja santization for GadgetHandler metadata

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by zhoresh

Modified:
15 years ago

Reviewers:
johnfargo, dev-remailer, mhermanto

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 15 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+76 lines, -11 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetContext.java	View	1 chunk	+9 lines, -2 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java	View	2 chunks	+4 lines, -1 line	2 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java	View	7 chunks	+51 lines, -2 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/UriManagerTestBase.java	View	2 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mhermanto

It looks like you're passing cajolability through the system, which downstream, affects the URL generation. ...

15 years ago (2011-03-11 22:29:54 UTC) #2

zhoresh

15 years ago (2011-03-12 00:06:23 UTC) #3

Thanks!
Committed as 1080807

http://codereview.appspot.com/4252069/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
(right):

http://codereview.appspot.com/4252069/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java:161:
addParam(uri, Param.CAJOLE.getKey(), "1", useTpl, false);
On 2011/03/11 22:29:54, mhermanto wrote:
> Why not do same like previous stmts, with --
> addParam(uri, Param.CAJOLE.getKey(), context.getCajoled() ? "1" : "0", useTpl,
> false);

I just didn't like the added param if not needed (shorter url)

Expand All Messages | Collapse All Messages