Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(772)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4251049: Migrate icons to server & modules (client patch) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by nicoe
Modified:
14 years, 11 months ago
Reviewers:
udono, ced
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : removed print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7075 lines) Patch
R share/pixmaps/tryton/tryton-accessories.svg View 1 chunk +0 lines, -520 lines 0 comments Download
R share/pixmaps/tryton/tryton-calculator.svg View 1 chunk +0 lines, -642 lines 0 comments Download
R share/pixmaps/tryton/tryton-calendar.svg View 1 chunk +0 lines, -314 lines 0 comments Download
R share/pixmaps/tryton/tryton-clock.svg View 1 chunk +0 lines, -418 lines 0 comments Download
R share/pixmaps/tryton/tryton-currency.svg View 1 chunk +0 lines, -156 lines 0 comments Download
R share/pixmaps/tryton/tryton-development.svg View 1 chunk +0 lines, -327 lines 0 comments Download
R share/pixmaps/tryton/tryton-folder-saved-search.svg View 1 chunk +0 lines, -531 lines 0 comments Download
R share/pixmaps/tryton/tryton-graph.svg View 1 chunk +0 lines, -637 lines 0 comments Download
R share/pixmaps/tryton/tryton-image-missing.svg View 1 chunk +0 lines, -318 lines 0 comments Download
R share/pixmaps/tryton/tryton-list.svg View 1 chunk +0 lines, -348 lines 0 comments Download
R share/pixmaps/tryton/tryton-package.svg View 1 chunk +0 lines, -483 lines 0 comments Download
R share/pixmaps/tryton/tryton-presentation.svg View 1 chunk +0 lines, -565 lines 0 comments Download
R share/pixmaps/tryton/tryton-readonly.svg View 1 chunk +0 lines, -298 lines 0 comments Download
R share/pixmaps/tryton/tryton-spreadsheet.svg View 1 chunk +0 lines, -627 lines 0 comments Download
R share/pixmaps/tryton/tryton-tree.svg View 1 chunk +0 lines, -348 lines 0 comments Download
R share/pixmaps/tryton/tryton-users.svg View 1 chunk +0 lines, -537 lines 0 comments Download
M tryton/common/common.py View 1 3 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 7
nicoe
14 years, 11 months ago (2011-03-01 18:05:11 UTC) #1
udono
http://codereview.appspot.com/4251049/diff/1/tryton/common/common.py File tryton/common/common.py (right): http://codereview.appspot.com/4251049/diff/1/tryton/common/common.py#newcode52 tryton/common/common.py:52: print 'load_client_icons' remove debug code http://codereview.appspot.com/4251049/diff/1/tryton/common/common.py#newcode88 tryton/common/common.py:88: or iconname ...
14 years, 11 months ago (2011-03-01 20:30:21 UTC) #2
ced
The refresh code should be in a separate changeset
14 years, 11 months ago (2011-03-01 23:40:31 UTC) #3
nicoe
On 2011/03/01 23:40:31, ced wrote: > The refresh code should be in a separate changeset ...
14 years, 11 months ago (2011-03-02 10:04:51 UTC) #4
nicoe
http://codereview.appspot.com/4251049/diff/1/tryton/common/common.py File tryton/common/common.py (right): http://codereview.appspot.com/4251049/diff/1/tryton/common/common.py#newcode52 tryton/common/common.py:52: print 'load_client_icons' On 2011/03/01 20:30:21, udono wrote: > remove ...
14 years, 11 months ago (2011-03-02 10:08:07 UTC) #5
nicoe
14 years, 11 months ago (2011-03-02 10:54:30 UTC) #6
ced
14 years, 11 months ago (2011-03-02 12:35:16 UTC) #7 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b