Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 4251047: code review 4251047: doc changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by adg
Modified:
14 years ago
Reviewers:
CC:
rsc, r, r2, golang-dev
Visibility:
Public.

Description

doc: add FAQ about large binaries and stack vs heap allocation doc: add internationalization to roadmap

Patch Set 1 #

Patch Set 2 : diff -r 4c0a44d9a0f6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4c0a44d9a0f6 https://go.googlecode.com/hg/ #

Total comments: 8

Patch Set 4 : diff -r 4c0a44d9a0f6 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4c0a44d9a0f6 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 6 : diff -r cd634481df9f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M doc/devel/roadmap.html View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M doc/go_faq.html View 1 2 3 4 5 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 14
adg
Hello rsc, r, I'd like you to review this change to https://go.googlecode.com/hg/
14 years ago (2011-03-01 02:07:37 UTC) #1
adg
Looks like another FAQ about stack vs heap allocation snuck in there. Review that too, ...
14 years ago (2011-03-01 02:12:34 UTC) #2
rsc
s/q_stack_v_heap/stack_or_heap/ or follow the usual convention
14 years ago (2011-03-01 02:26:59 UTC) #3
rsc
I'm not sure about adding dynamic linking to the road map. It's definitely not on ...
14 years ago (2011-03-01 02:27:24 UTC) #4
adg
On 1 March 2011 13:27, Russ Cox <rsc@golang.org> wrote: > I'm not sure about adding ...
14 years ago (2011-03-01 02:29:57 UTC) #5
rsc
> Fine. That's why I sent it for review off-list. Removed from CL. Tricky. :-)
14 years ago (2011-03-01 02:31:32 UTC) #6
r2
i was going to add something about internationalization to the road map. might as well ...
14 years ago (2011-03-01 04:53:18 UTC) #7
adg
Done. PTAL. http://codereview.appspot.com/4251047/ On 1 March 2011 15:53, Rob 'Commander' Pike <r@google.com> wrote: > i ...
14 years ago (2011-03-01 04:57:20 UTC) #8
r
http://codereview.appspot.com/4251047/diff/10001/doc/devel/roadmap.html File doc/devel/roadmap.html (right): http://codereview.appspot.com/4251047/diff/10001/doc/devel/roadmap.html#newcode51 doc/devel/roadmap.html:51: Comprehensive internationalization support. no need for noun phrase. the ...
14 years ago (2011-03-01 05:08:09 UTC) #9
rsc
i think the heap or stack question should start by saying "you don't need to ...
14 years ago (2011-03-01 05:19:56 UTC) #10
r2
On Feb 28, 2011, at 9:19 PM, Russ Cox wrote: > i think the heap ...
14 years ago (2011-03-01 05:26:05 UTC) #11
adg
PTAL
14 years ago (2011-03-01 05:50:30 UTC) #12
r
LGTM http://codereview.appspot.com/4251047/diff/12004/doc/go_faq.html File doc/go_faq.html (right): http://codereview.appspot.com/4251047/diff/12004/doc/go_faq.html#newcode965 doc/go_faq.html:965: runtime, along with the runtime type information necessary ...
14 years ago (2011-03-01 07:40:56 UTC) #13
adg
14 years ago (2011-03-01 10:35:54 UTC) #14
*** Submitted as http://code.google.com/p/go/source/detail?r=0ef245a79bee ***

doc: add FAQ about large binaries and stack vs heap allocation
doc: add internationalization to roadmap

R=rsc, r, r2
CC=golang-dev
http://codereview.appspot.com/4251047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b