Changing access for some CssResponseRewriter and StyleTagProxyEmbeddedUrlsRewriter variables

In order to write useful sub-classes for CssResponseRewriter and StyleTagProxyEmbeddedUrlsRewriter, we need to change the access modifiers for some of the variables in these 2 classes to protected/public as needed.

[gagan.goku, 2011-03-02 15:33:04]

small nits.

http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java
(right):

http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:225:
protected static class UriMaker {
keep this class public, some1 else might be using it outside shindig.
and why remove the final clause, do you want to extend this class ?

[anupama.dutta, 2011-03-03 05:56:45]

http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java
(right):

http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:225:
protected static class UriMaker {
On 2011/03/02 15:33:04, gagan.goku wrote:
> keep this class public, some1 else might be using it outside shindig.
> and why remove the final clause, do you want to extend this class ?

Good catch. Done.
Yes, I do want to extend this class - hence removing the final clause.

[nikhilmadan23, 2011-03-03 06:15:36]

On 2011/03/03 05:56:45, anupama.dutta wrote:
>
http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/a...
> File
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java
> (right):
> 
>
http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/a...
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:225:
> protected static class UriMaker {
> On 2011/03/02 15:33:04, gagan.goku wrote:
> > keep this class public, some1 else might be using it outside shindig.
> > and why remove the final clause, do you want to extend this class ?
> 
> Good catch. Done.
> Yes, I do want to extend this class - hence removing the final clause.

lgtm

[nikhilmadan23, 2011-03-03 06:15:37]

On 2011/03/03 05:56:45, anupama.dutta wrote:
>
http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/a...
> File
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java
> (right):
> 
>
http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/a...
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:225:
> protected static class UriMaker {
> On 2011/03/02 15:33:04, gagan.goku wrote:
> > keep this class public, some1 else might be using it outside shindig.
> > and why remove the final clause, do you want to extend this class ?
> 
> Good catch. Done.
> Yes, I do want to extend this class - hence removing the final clause.

lgtm

[gagan.goku, 2011-03-03 06:47:43]

Build looks good.
Committed as r1076536.

[anupama.dutta, 2011-03-03 07:04:20]

Thanks for the prompt commit!

On Thu, Mar 3, 2011 at 12:17 PM, <gagan.goku@gmail.com> wrote:

> Build looks good.
> Committed as r1076536.
>
>
> http://codereview.appspot.com/4250051/
>

[gagan.goku, 2011-03-03 07:07:59]

ur welcome.

-- 
The only thing missing in life is background music.
-- Gagandeep Singh


On Thu, Mar 3, 2011 at 12:34 PM, Anupama Dutta <anupama.dutta@gmail.com>wrote:

> Thanks for the prompt commit!
>
>
> On Thu, Mar 3, 2011 at 12:17 PM, <gagan.goku@gmail.com> wrote:
>
>> Build looks good.
>> Committed as r1076536.
>>
>>
>> http://codereview.appspot.com/4250051/
>>
>
>