Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(402)

Issue 4250051: Changing access for some CssResponseRewriter and StyleTagProxyEmbeddedUrlsRewriter variables (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by anupama.dutta
Modified:
14 years, 11 months ago
Reviewers:
nikhilmadan23, dev-remailer, cool-shindig-committers, gagan.goku
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

In order to write useful sub-classes for CssResponseRewriter and StyleTagProxyEmbeddedUrlsRewriter, we need to change the access modifiers for some of the variables in these 2 classes to protected/public as needed.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java View 1 2 chunks +6 lines, -6 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsRewriter.java View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8
anupama.dutta
15 years ago (2011-03-02 12:37:01 UTC) #1
gagan.goku
small nits. http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java (right): http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java#newcode225 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:225: protected static class UriMaker { keep this ...
15 years ago (2011-03-02 15:33:04 UTC) #2
anupama.dutta
http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java (right): http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java#newcode225 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:225: protected static class UriMaker { On 2011/03/02 15:33:04, gagan.goku ...
15 years ago (2011-03-03 05:56:45 UTC) #3
nikhilmadan23
On 2011/03/03 05:56:45, anupama.dutta wrote: > http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java > File > java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java > (right): > > ...
15 years ago (2011-03-03 06:15:36 UTC) #4
nikhilmadan23
On 2011/03/03 05:56:45, anupama.dutta wrote: > http://codereview.appspot.com/4250051/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java > File > java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java > (right): > > ...
15 years ago (2011-03-03 06:15:37 UTC) #5
gagan.goku
Build looks good. Committed as r1076536.
15 years ago (2011-03-03 06:47:43 UTC) #6
anupama.dutta
Thanks for the prompt commit! On Thu, Mar 3, 2011 at 12:17 PM, <gagan.goku@gmail.com> wrote: ...
15 years ago (2011-03-03 07:04:20 UTC) #7
gagan.goku
15 years ago (2011-03-03 07:07:59 UTC) #8
ur welcome.

-- 
The only thing missing in life is background music.
-- Gagandeep Singh


On Thu, Mar 3, 2011 at 12:34 PM, Anupama Dutta <anupama.dutta@gmail.com>wrote:

> Thanks for the prompt commit!
>
>
> On Thu, Mar 3, 2011 at 12:17 PM, <gagan.goku@gmail.com> wrote:
>
>> Build looks good.
>> Committed as r1076536.
>>
>>
>> http://codereview.appspot.com/4250051/
>>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b