code review 4249065: spec: remove closed from language, replaced by x, ok = <-c

spec: remove closed from language, replaced by x, ok = <-c

[rsc, 2011-03-10 15:41:48]

Hello gri, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-03-10 17:09:54]

http://codereview.appspot.com/4249065/diff/4001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4249065/diff/4001/doc/go_spec.html#newcode2
doc/go_spec.html:2: <!-- subtitle Version of March 7, 2011 -->
Please update the date.

http://codereview.appspot.com/4249065/diff/4001/doc/go_spec.html#newcode1238
doc/go_spec.html:1238: A channel may be closed and tested for closure with the
built-in functions
This needs to be adjusted.

http://codereview.appspot.com/4249065/diff/4001/doc/go_spec.html#newcode4010
doc/go_spec.html:4010: (§<a href="#Close_and_closed"><code>close</code> and
<code>closed</code></a>).
This needs to be adjusted.

http://codereview.appspot.com/4249065/diff/4001/doc/go_spec.html#newcode4085
doc/go_spec.html:4085: RecvStmt =  [ Expression [ "," Expression ] ( "=" | ":="
) ] RecvExpr .
= not aligned

http://codereview.appspot.com/4249065/diff/4001/doc/go_spec.html#newcode4118
doc/go_spec.html:4118: The receive case may declare a new variable or variables
using a
maybe:
... may declare one or two new variables using ...

[rsc, 2011-03-11 15:08:34]

Hello gri, r (cc: golang-dev@googlegroups.com),

Please take another look.

[gri, 2011-03-11 19:15:04]

http://codereview.appspot.com/4249065/diff/8001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4249065/diff/8001/doc/go_spec.html#newcode1239
doc/go_spec.html:1239: <a href="#Close"><code>close</code></a> and tested
maybe two sentences?

s/ and tested.../. The multi-valued assignment form of the <a
href="#Receive_operator">receive operator</a> may be used to test a channel for
closure./

http://codereview.appspot.com/4249065/diff/8001/doc/go_spec.html#newcode1240
doc/go_spec.html:1240: for closure using a two-element assignment form of the
s/two-element/multi-valued/

(see line 4405: uses multi-valued. use same terminology in both places)

http://codereview.appspot.com/4249065/diff/8001/doc/go_spec.html#newcode1501
doc/go_spec.html:1501: append cap close closed complex copy imag len
s/closed //

[r, 2011-03-11 19:20:35]

http://codereview.appspot.com/4249065/diff/8001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4249065/diff/8001/doc/go_spec.html#newcode1240
doc/go_spec.html:1240: for closure using a two-element assignment form of the
that's not what closure usually means. confusing term. two sentences

A channel may be closed with the built-in function close.  A two-element
assignment form of the receiver operator may be used to check whether it has
been closed.

[rsc, 2011-03-11 19:21:53]

crossed in the mail; i have now (not uploaded):

A channel may be closed with the built-in function
<a href="#Close"><code>close</code></a>; the
multi-valued assignment form of the
<a href="#Receive_operator">receive operator</a>
tests whether a channel is closed.
</p>

[r2, 2011-03-11 19:22:37]

LGTM

[rsc, 2011-03-11 19:23:22]

Hello gri, r, r2 (cc: golang-dev@googlegroups.com),

Please take another look.

[gri, 2011-03-11 19:24:44]

LGTM

[r, 2011-03-11 19:25:29]

LGTM

http://codereview.appspot.com/4249065/diff/16001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4249065/diff/16001/doc/go_spec.html#newcode1242
doc/go_spec.html:1242: tests whether a channel is closed.
s/is/has been/ ??

[rsc, 2011-03-11 19:27:40]

has been it is.

[rsc, 2011-03-11 19:47:07]

*** Submitted as 1af084d5182c ***

spec: remove closed from language, replaced by x, ok = <-c

R=gri, r, r2
CC=golang-dev
http://codereview.appspot.com/4249065