src/pkg/http/cgi/host.go - Issue 4248075: code review 4248075: http: move RemoteAddr & UsingTLS from ResponseWriter to...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/http/cgi/host.go

Issue 4248075: code review 4248075: http: move RemoteAddr & UsingTLS from ResponseWriter to... (Closed)

Patch Set: diff -r ca4f5cc00121 https://go.googlecode.com/hg/ Created 14 years ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/http/cgi/host.go

===================================================================

--- a/src/pkg/http/cgi/host.go

+++ b/src/pkg/http/cgi/host.go

@@ -74,11 +74,15 @@

"PATH_INFO=" + pathInfo,

"SCRIPT_NAME=" + root,

"SCRIPT_FILENAME=" + h.Path,

- "REMOTE_ADDR=" + rw.RemoteAddr(),

- "REMOTE_HOST=" + rw.RemoteAddr(),

+ "REMOTE_ADDR=" + req.RemoteAddr,

+ "REMOTE_HOST=" + req.RemoteAddr,

"SERVER_PORT=" + port,

}

+ if req.TLS != nil {

+ env = append(env, "HTTPS=on")

+ }

if len(req.Cookie) > 0 {

b := new(bytes.Buffer)

for idx, c := range req.Cookie {

« no previous file with comments | « src/cmd/godoc/main.go ('k') | src/pkg/http/cgi/host_test.go » ('j') | no next file with comments »