Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(324)

Issue 4248049: Migrate icons to server & modules (server patch) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by nicoe
Modified:
14 years, 11 months ago
Reviewers:
udono, ced
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use selection for ir.ui.menu icon field. Added copyright files. #

Total comments: 2

Patch Set 3 : Added copyright notice #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4202 lines, -27 lines) Patch
M MANIFEST.in View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/ir/__tryton__.py View 1 chunk +1 line, -0 lines 0 comments Download
A trytond/ir/ui/icons.xml View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A trytond/ir/ui/icons/LICENSE View 1 2 1 chunk +264 lines, -0 lines 0 comments Download
A trytond/ir/ui/icons/tryton-calendar.svg View 1 chunk +314 lines, -0 lines 0 comments Download
A trytond/ir/ui/icons/tryton-clock.svg View 1 chunk +418 lines, -0 lines 0 comments Download
A trytond/ir/ui/icons/tryton-graph.svg View 1 chunk +637 lines, -0 lines 0 comments Download
A trytond/ir/ui/icons/tryton-image-missing.svg View 1 chunk +318 lines, -0 lines 0 comments Download
A trytond/ir/ui/icons/tryton-list.svg View 1 chunk +348 lines, -0 lines 0 comments Download
A trytond/ir/ui/icons/tryton-presentation.svg View 1 chunk +565 lines, -0 lines 0 comments Download
A trytond/ir/ui/icons/tryton-readonly.svg View 1 chunk +298 lines, -0 lines 0 comments Download
A trytond/ir/ui/icons/tryton-spreadsheet.svg View 1 chunk +627 lines, -0 lines 0 comments Download
A trytond/ir/ui/icons/tryton-tree.svg View 1 chunk +348 lines, -0 lines 0 comments Download
M trytond/ir/ui/menu.py View 1 3 chunks +19 lines, -27 lines 0 comments Download

Messages

Total messages: 7
nicoe
14 years, 11 months ago (2011-03-01 18:06:01 UTC) #1
udono
http://codereview.appspot.com/4248049/diff/1/trytond/ir/ui/menu.py File trytond/ir/ui/menu.py (right): http://codereview.appspot.com/4248049/diff/1/trytond/ir/ui/menu.py#newcode28 trytond/ir/ui/menu.py:28: icon = fields.Char('Icon') why not fields.Selection with a getter ...
14 years, 11 months ago (2011-03-01 20:33:30 UTC) #2
ced
You must update MANIFEST.in and add the Creative Commons license in icons folder
14 years, 11 months ago (2011-03-01 23:43:24 UTC) #3
nicoe
14 years, 11 months ago (2011-03-02 10:55:28 UTC) #4
ced
http://codereview.appspot.com/4248049/diff/4002/MANIFEST.in File MANIFEST.in (right): http://codereview.appspot.com/4248049/diff/4002/MANIFEST.in#newcode19 MANIFEST.in:19: include trytond/ir/ui/icons/*svg *.svg http://codereview.appspot.com/4248049/diff/4002/trytond/ir/ui/icons.xml File trytond/ir/ui/icons.xml (right): http://codereview.appspot.com/4248049/diff/4002/trytond/ir/ui/icons.xml#newcode1 trytond/ir/ui/icons.xml:1: ...
14 years, 11 months ago (2011-03-02 12:41:53 UTC) #5
nicoe
14 years, 11 months ago (2011-03-02 12:48:42 UTC) #6
ced
14 years, 11 months ago (2011-03-02 12:54:45 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b