Issue 4247047: code review 4247047: bzip2: speed up decompression.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4247047: code review 4247047: bzip2: speed up decompression. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by agl1

Modified:
14 years ago

Reviewers:

CC:
bradfitz, bradfitzgoog, cw, golang-dev

Visibility:
Public.

Description

bzip2: speed up decompression. This borrows a trick from the bzip2 source and effects a decent speed up when decompressing highly compressed sources. Rather than unshuffle the BTW block when performing the IBTW, a linked-list is threaded through the array, in place. This improves cache hit rates.

Patch Set 1 #

Patch Set 2 : diff -r ddd74c3b61f8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 44f9c2300d17 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -27 lines)			Patch
	M	src/pkg/compress/bzip2/bzip2.go	View	1	8 chunks	+44 lines, -27 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

agl1

Hello bradfitzgo, bradfitzwork, cw (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-03-03 14:13:05 UTC) #4

agl1

14 years ago (2011-03-03 14:13:18 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=483e1b635f9e ***

bzip2: speed up decompression.

This borrows a trick from the bzip2 source and effects a decent speed
up when decompressing highly compressed sources. Rather than unshuffle
the BTW block when performing the IBTW, a linked-list is threaded
through the array, in place. This improves cache hit rates.

R=bradfitzgo, bradfitzwork, cw
CC=golang-dev
http://codereview.appspot.com/4247047

Expand All Messages | Collapse All Messages