Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(192)

Issue 4247047: code review 4247047: bzip2: speed up decompression. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by agl1
Modified:
14 years ago
Reviewers:
CC:
bradfitz, bradfitzgoog, cw, golang-dev
Visibility:
Public.

Description

bzip2: speed up decompression. This borrows a trick from the bzip2 source and effects a decent speed up when decompressing highly compressed sources. Rather than unshuffle the BTW block when performing the IBTW, a linked-list is threaded through the array, in place. This improves cache hit rates.

Patch Set 1 #

Patch Set 2 : diff -r ddd74c3b61f8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 44f9c2300d17 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -27 lines) Patch
M src/pkg/compress/bzip2/bzip2.go View 1 8 chunks +44 lines, -27 lines 0 comments Download

Messages

Total messages: 5
agl1
14 years ago (2011-03-02 21:09:59 UTC) #1
bradfitzgoog
LGTM
14 years ago (2011-03-02 21:17:21 UTC) #2
cw
LGTM (31% speedup on highly compressed data)
14 years ago (2011-03-03 08:00:34 UTC) #3
agl1
Hello bradfitzgo, bradfitzwork, cw (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years ago (2011-03-03 14:13:05 UTC) #4
agl1
14 years ago (2011-03-03 14:13:18 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=483e1b635f9e ***

bzip2: speed up decompression.

This borrows a trick from the bzip2 source and effects a decent speed
up when decompressing highly compressed sources. Rather than unshuffle
the BTW block when performing the IBTW, a linked-list is threaded
through the array, in place. This improves cache hit rates.

R=bradfitzgo, bradfitzwork, cw
CC=golang-dev
http://codereview.appspot.com/4247047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b