Issue 4245077: code review 4245077: go/ast: ast.Print needs a file set to print position va...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4245077: code review 4245077: go/ast: ast.Print needs a file set to print position va... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by gri

Modified:
14 years ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

go/ast: ast.Print needs a file set to print position values nicely Also removed a TODO (AST nodes have been restructured a while ago).

Patch Set 1 #

Patch Set 2 : diff -r 15258ffb8236 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 15258ffb8236 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 15258ffb8236 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r a370230a43c9 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
	M	src/pkg/go/ast/print.go	View	1 2	4 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-03-10 19:49:38 UTC) #1

gri

14 years ago (2011-03-10 20:54:35 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=c05f1a235478 ***

go/ast: ast.Print needs a file set to print position values nicely

Also removed a TODO (AST nodes have been restructured a while ago).

R=r
CC=golang-dev
http://codereview.appspot.com/4245077

Expand All Messages | Collapse All Messages