Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(257)

Issue 4245065: code review 4245065: http: close after responding to HTTP/1.0 request withou... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by rsc
Modified:
11 years, 10 months ago
Reviewers:
bradfitz
CC:
adg, golang-dev
Visibility:
Public.

Description

http: close after responding to HTTP/1.0 request without Connection: keep-alive

Patch Set 1 #

Patch Set 2 : diff -r 4cf2dfa78382 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4cf2dfa78382 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4cf2dfa78382 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4cf2dfa78382 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 4ea8f8f3c643 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/pkg/http/server.go View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 10 months ago (2011-03-07 05:01:50 UTC) #1
adg
LGTM On 7 March 2011 16:01, <rsc@golang.org> wrote: > Reviewers: adg, > > Message: > ...
11 years, 10 months ago (2011-03-07 05:04:13 UTC) #2
rsc
Hello adg (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 10 months ago (2011-03-07 05:09:39 UTC) #3
adg
LGTM
11 years, 10 months ago (2011-03-07 05:12:34 UTC) #4
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=7b94e70ee7f4 *** http: close after responding to HTTP/1.0 request without Connection: keep-alive ...
11 years, 10 months ago (2011-03-07 05:14:45 UTC) #5
bradfitz
11 years, 10 months ago (2011-03-07 05:38:02 UTC) #6
CL lacks tests.

I will probably break this again in the future.


On Sun, Mar 6, 2011 at 9:14 PM, <rsc@golang.org> wrote:

> *** Submitted as
> http://code.google.com/p/go/source/detail?r=7b94e70ee7f4 ***
>
> http: close after responding to HTTP/1.0 request without Connection:
> keep-alive
>
> R=adg
> CC=golang-dev
>
> http://codereview.appspot.com/4245065
>
>
> http://codereview.appspot.com/4245065/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b