code review 4244045: http: export parseHTTPVersion.

http: export parseHTTPVersion.

[dsymonds, 2011-03-01 11:11:52]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-03-01 11:15:13]

LGTM

On 1 March 2011 22:11,  <dsymonds@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> http: export parseHTTPVersion.
>
> Please review this at http://codereview.appspot.com/4244045/
>
> Affected files:
>  M src/pkg/http/request.go
>  M src/pkg/http/response.go
>
>
> Index: src/pkg/http/request.go
> ===================================================================
> --- a/src/pkg/http/request.go
> +++ b/src/pkg/http/request.go
> @@ -315,8 +315,9 @@
>        return n, i, true
>  }
>
> -// Parse HTTP version: "HTTP/1.2" -> (1, 2, true).
> -func parseHTTPVersion(vers string) (int, int, bool) {
> +// ParseHTTPVersion parses a HTTP version string.
> +// "HTTP/1.2" returns (1, 2, true).
> +func ParseHTTPVersion(vers string) (major, minor int, ok bool) {
>        if len(vers) < 5 || vers[0:5] != "HTTP/" {
>                return 0, 0, false
>        }
> @@ -324,7 +325,6 @@
>        if !ok || i >= len(vers) || vers[i] != '.' {
>                return 0, 0, false
>        }
> -       var minor int
>        minor, i, ok = atoi(vers, i+1)
>        if !ok || i != len(vers) {
>                return 0, 0, false
> @@ -416,7 +416,7 @@
>        }
>        req.Method, req.RawURL, req.Proto = f[0], f[1], f[2]
>        var ok bool
> -       if req.ProtoMajor, req.ProtoMinor, ok = parseHTTPVersion(req.Proto);
> !ok {
> +       if req.ProtoMajor, req.ProtoMinor, ok = ParseHTTPVersion(req.Proto);
> !ok {
>                return nil, &badStringError{"malformed HTTP version",
> req.Proto}
>        }
>
> Index: src/pkg/http/response.go
> ===================================================================
> --- a/src/pkg/http/response.go
> +++ b/src/pkg/http/response.go
> @@ -106,7 +106,7 @@
>
>        resp.Proto = f[0]
>        var ok bool
> -       if resp.ProtoMajor, resp.ProtoMinor, ok =
> parseHTTPVersion(resp.Proto); !ok {
> +       if resp.ProtoMajor, resp.ProtoMinor, ok =
> ParseHTTPVersion(resp.Proto); !ok {
>                return nil, &badStringError{"malformed HTTP version",
> resp.Proto}
>        }
>
>
>
>

[dsymonds, 2011-03-01 11:38:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=c46e7e3c0271 ***

http: export parseHTTPVersion.

R=rsc, adg
CC=golang-dev
http://codereview.appspot.com/4244045

[rsc, 2011-03-01 12:56:57]

It'd be nice if the example were real.
HTTP/1.0 not HTTP/1.2