code review 4243072: go code: replace closed(c) with x, ok := <-c

go code: replace closed(c) with x, ok := <-c

[rsc, 2011-03-10 14:50:58]

Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rog, 2011-03-10 15:05:31]

On 2011/03/10 14:50:58, rsc wrote:
> Hello golang-dev (cc: mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

LGTM
i'm quite surprised there aren't more uses of it.

[bradfitzgoog, 2011-03-10 15:09:42]

LGTM

http://codereview.appspot.com/4243072/diff/5001/src/pkg/os/inotify/inotify_li...
File src/pkg/os/inotify/inotify_linux_test.go (left):

http://codereview.appspot.com/4243072/diff/5001/src/pkg/os/inotify/inotify_li...
src/pkg/os/inotify/inotify_linux_test.go:68: for !closed(eventstream) {
nice killing this

http://codereview.appspot.com/4243072/diff/5001/src/pkg/os/inotify/inotify_li...
File src/pkg/os/inotify/inotify_linux_test.go (right):

http://codereview.appspot.com/4243072/diff/5001/src/pkg/os/inotify/inotify_li...
src/pkg/os/inotify/inotify_linux_test.go:72: case <-time.After(1e9):
ooh, I hadn't seen this style before.  I always wasted a temporary or something.

http://codereview.appspot.com/4243072/diff/5001/test/chan/select3.go
File test/chan/select3.go (right):

http://codereview.appspot.com/4243072/diff/5001/test/chan/select3.go#newcode46
test/chan/select3.go:46: time.Sleep(1e8) // 0.1s seems plenty long
unrelated but curious:  could you use something like an idler goroutine to make
this test not depend on a fixed timeout?

[rog, 2011-03-10 15:20:34]

On 10 March 2011 15:09,  <bradfitz@google.com> wrote:
>
http://codereview.appspot.com/4243072/diff/5001/src/pkg/os/inotify/inotify_li...
> src/pkg/os/inotify/inotify_linux_test.go:72: case <-time.After(1e9):
> ooh, I hadn't seen this style before.  I always wasted a temporary or
> something.

if you've got a long timeout in a fast loop, it's still worth cleaning up the
Timer, as garbage timers can build up.

[r, 2011-03-10 17:17:34]

LGTM

[rsc, 2011-03-11 19:47:47]

*** Submitted as 604d3ae2f22e ***

go code: replace closed(c) with x, ok := <-c

R=golang-dev, rog, bradfitzwork, r
CC=golang-dev
http://codereview.appspot.com/4243072