Issue 4241043: code review 4241043: sync: use sync/atomic

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4241043: code review 4241043: sync: use sync/atomic (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by rsc

Modified:
14 years ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

sync: use sync/atomic Remove references to custom assembly routines.

Patch Set 1 #

Patch Set 2 : diff -r d9ff478c4ed3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d9ff478c4ed3 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 035720db5bdc https://go.googlecode.com/hg #

Patch Set 5 : diff -r b5fbdfb23f4f https://go.googlecode.com/hg #

Patch Set 6 : diff -r 9857d5ce1506 https://go.googlecode.com/hg #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -176 lines)			Patch
M	src/pkg/sync/Makefile	View	1	1 chunk	+0 lines, -17 lines	0 comments	Download
R	src/pkg/sync/asm_386.s	View	1 3	1 chunk	+0 lines, -23 lines	0 comments	Download
R	src/pkg/sync/asm_amd64.s	View	1 3	1 chunk	+0 lines, -23 lines	0 comments	Download
R	src/pkg/sync/asm_arm5.s	View	1 3	1 chunk	+0 lines, -40 lines	0 comments	Download
R	src/pkg/sync/asm_arm6.s	View	1 3	1 chunk	+0 lines, -30 lines	0 comments	Download
A	src/pkg/sync/atomic/asm_linux_arm.s	View	1 2 3	1 chunk	+68 lines, -0 lines	0 comments	Download
M	src/pkg/sync/cond_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/sync/mutex.go	View	1	3 chunks	+8 lines, -21 lines	0 comments	Download
M	src/pkg/sync/rwmutex.go	View	1	4 chunks	+7 lines, -5 lines	0 comments	Download
M	src/pkg/sync/rwmutex_test.go	View	1	3 chunks	+8 lines, -7 lines	0 comments	Download
R	src/pkg/sync/xadd_test.go	View	1 3	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-02-25 18:14:00 UTC) #1

rsc

14 years ago (2011-02-25 19:29:49 UTC) #3

*** Submitted as 51e1539c025c ***

sync: use sync/atomic

Remove references to custom assembly routines.

R=r, r2
CC=golang-dev
http://codereview.appspot.com/4241043

Expand All Messages | Collapse All Messages