code review 4240100: Effective Go: some small cleanups.

Effective Go: some small cleanups.
Add discussion of getters.
Add example using a map as a set.

[r, 2011-03-09 23:25:10]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-03-09 23:34:28]

LGTM

http://codereview.appspot.com/4240100/diff/1/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/4240100/diff/1/doc/effective_go.html#newcode98
doc/effective_go.html:98: All Go code in the repository has been formatted with
<code>gofmt</code>.
This is not 100% true but probably can be made true (e.g. illegal source tests
are not gofmt'ed, but also some legal code isn't). See output of:

gofmt -l $GOROOT

http://codereview.appspot.com/4240100/diff/1/doc/effective_go.html#newcode346
doc/effective_go.html:346: the field from the method.
perhaps add:

If the getter is not exorted (and thus would cause a conflict with the
fieldname), it may not be justified in the first place.

[adg, 2011-03-09 23:36:55]

LGTM

http://codereview.appspot.com/4240100/diff/1/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/4240100/diff/1/doc/effective_go.html#newcode62
doc/effective_go.html:62: A custom tool, <code>gofmt</code>, reads a Go program
What makes gofmt "custom"? It's just a tool like any other, isn't it?

http://codereview.appspot.com/4240100/diff/1/doc/effective_go.html#newcode347
doc/effective_go.html:347: Of course a setter function, if needed, will likely
be called <code>SetOwner</code>.
s/Of course a/A/

http://codereview.appspot.com/4240100/diff/1/doc/effective_go.html#newcode839
doc/effective_go.html:839: Deferring a function such as <code>Close</code> has
two advantages.  First, it
s/function/function call/

[iant, 2011-03-09 23:50:16]

LGTM

http://codereview.appspot.com/4240100/diff/3001/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/4240100/diff/3001/doc/effective_go.html#newcode515
doc/effective_go.html:515: This is a example of a common situation where code
must guard against a
s/a example/an example/

[r, 2011-03-10 00:47:47]

*** Submitted as http://code.google.com/p/go/source/detail?r=a04c14d2db22 ***

Effective Go: some small cleanups.
Add discussion of getters.
Add example using a map as a set.

R=golang-dev, gri, adg, iant
CC=golang-dev
http://codereview.appspot.com/4240100