Issue 4240086: code review 4240086: http: fix cookie_test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4240086: code review 4240086: http: fix cookie_test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by rsc

Modified:
14 years, 1 month ago

Reviewers:

CC:
bradfitz, bradfitzgoog, golang-dev

Visibility:
Public.

Description

http: fix cookie_test Was only breaking on some dashboard builds because not all run the network tests.

Patch Set 1 #

Patch Set 2 : diff -r eb24c3668d9f https://go.googlecode.com/hg #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
	M	src/pkg/http/cookie_test.go	View		6 chunks	+21 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello bradfitzgo (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-03-07 19:40:37 UTC) #1

rsc

14 years, 1 month ago (2011-03-07 19:45:52 UTC) #3

*** Submitted as af83aa41994c ***

http: fix cookie_test

Was only breaking on some dashboard builds because
not all run the network tests.

R=bradfitzgo, bradfitzwork
CC=golang-dev
http://codereview.appspot.com/4240086

Expand All Messages | Collapse All Messages