Infinite loop with error dialog patch

[ced, 2011-03-06 00:41:06]

http://codereview.appspot.com/4240076/diff/1/tryton/common/common.py
File tryton/common/common.py (right):

http://codereview.appspot.com/4240076/diff/1/tryton/common/common.py#newcode552
tryton/common/common.py:552: label_roundup.set_markup(_('To report bugs you must
have an account on ') \
80 cols

http://codereview.appspot.com/4240076/diff/1/tryton/gui/window/view_form/mode...
File tryton/gui/window/view_form/model/record.py (right):

http://codereview.appspot.com/4240076/diff/1/tryton/gui/window/view_form/mode...
tryton/gui/window/view_form/model/record.py:38: self.exception_record = False
I would name it exception_read instead.
It is on Record so _record is duplicate.

http://codereview.appspot.com/4240076/diff/1/tryton/gui/window/view_form/mode...
tryton/gui/window/view_form/model/record.py:85: values = [{'id': x} for x in
ids]
Why not setting here the default False values?

[nicoe, 2011-03-09 10:50:34]

http://codereview.appspot.com/4240076/diff/1/tryton/common/common.py
File tryton/common/common.py (right):

http://codereview.appspot.com/4240076/diff/1/tryton/common/common.py#newcode552
tryton/common/common.py:552: label_roundup.set_markup(_('To report bugs you must
have an account on ') \
On 2011/03/06 00:41:06, ced wrote:
> 80 cols

Done.

http://codereview.appspot.com/4240076/diff/1/tryton/gui/window/view_form/mode...
File tryton/gui/window/view_form/model/record.py (right):

http://codereview.appspot.com/4240076/diff/1/tryton/gui/window/view_form/mode...
tryton/gui/window/view_form/model/record.py:38: self.exception_record = False
On 2011/03/06 00:41:06, ced wrote:
> I would name it exception_read instead.
> It is on Record so _record is duplicate.

Done.

http://codereview.appspot.com/4240076/diff/1/tryton/gui/window/view_form/mode...
tryton/gui/window/view_form/model/record.py:85: values = [{'id': x} for x in
ids]
On 2011/03/06 00:41:06, ced wrote:
> Why not setting here the default False values?

Done.

[vincentvdl, 2011-03-10 16:23:01]

Hi,

I have "no access" Model Access (= model access record with no
read/write/create/delete rights) assigned to a certain model (no group).

Then I made sure that one of the users did not have access to this certain model
(thanks to the model access record defined above).

When I now double-click the menu-item with this user (Ubuntu), I get a blank
error dialog (no message or icon is shown), when I press the dialog's X button,
a few times I finally see a dialog with "You can not read this document" error.

Before I applying this patch I would get infinite blank messageboxes.

[ced, 2011-03-21 16:44:42]

http://codereview.appspot.com/4240076/diff/7001/tryton/common/common.py
File tryton/common/common.py (right):

http://codereview.appspot.com/4240076/diff/7001/tryton/common/common.py#newco...
tryton/common/common.py:695: def message(msg, parent,
msg_type=gtk.MESSAGE_INFO):
Should do the same

http://codereview.appspot.com/4240076/diff/7001/tryton/common/common.py#newco...
tryton/common/common.py:709: def warning(msg, parent, title=''):
Should do the same

http://codereview.appspot.com/4240076/diff/7001/tryton/common/common.py#newco...
tryton/common/common.py:725: def userwarning(msg, parent, title=''):
Should do the same

http://codereview.appspot.com/4240076/diff/7001/tryton/common/common.py#newco...
tryton/common/common.py:750: def sur(msg, parent):
Should do the same

http://codereview.appspot.com/4240076/diff/7001/tryton/common/common.py#newco...
tryton/common/common.py:776: def sur_3b(msg, parent):
Should do the same

http://codereview.appspot.com/4240076/diff/7001/tryton/common/common.py#newco...
tryton/common/common.py:811: def ask(question, parent, visibility=True):
Idem

http://codereview.appspot.com/4240076/diff/7001/tryton/common/common.py#newco...
tryton/common/common.py:844: def concurrency(resource, obj_id, context, parent):
Idem

[ced, 2011-04-01 15:21:17]

http://codereview.appspot.com/4240076/diff/13001/tryton/common/common.py
File tryton/common/common.py (right):

http://codereview.appspot.com/4240076/diff/13001/tryton/common/common.py#newc...
tryton/common/common.py:492: dialog = self.build_dialog(*args)
Better to define build_dialog that will raise NotImplemented

http://codereview.appspot.com/4240076/diff/13001/tryton/common/common.py#newc...
tryton/common/common.py:698: Window.create(False, resource, obj_id, [('id', '=',
obj_id)], 'form',
80 cols

[nicoe, 2011-04-01 15:49:35]

http://codereview.appspot.com/4240076/diff/13001/tryton/common/common.py
File tryton/common/common.py (right):

http://codereview.appspot.com/4240076/diff/13001/tryton/common/common.py#newc...
tryton/common/common.py:492: dialog = self.build_dialog(*args)
On 2011/04/01 15:21:18, ced wrote:
> Better to define build_dialog that will raise NotImplemented

Done.

http://codereview.appspot.com/4240076/diff/13001/tryton/common/common.py#newc...
tryton/common/common.py:698: Window.create(False, resource, obj_id, [('id', '=',
obj_id)], 'form',
On 2011/04/01 15:21:18, ced wrote:
> 80 cols

Done.

[ced, 2011-04-07 13:45:42]

LGTM