Change threading to support @#@¼@|{{! Windows XP

[udono, 2011-03-03 17:08:14]

http://codereview.appspot.com/4237054/diff/3001/tryton/gui/window/dblogin.py
File tryton/gui/window/dblogin.py (right):

http://codereview.appspot.com/4237054/diff/3001/tryton/gui/window/dblogin.py#...
tryton/gui/window/dblogin.py:3: from __future__ import with_statement
no need

[nicoe, 2011-03-03 17:31:31]

http://codereview.appspot.com/4237054/diff/3001/tryton/gui/window/dblogin.py
File tryton/gui/window/dblogin.py (right):

http://codereview.appspot.com/4237054/diff/3001/tryton/gui/window/dblogin.py#...
tryton/gui/window/dblogin.py:3: from __future__ import with_statement
On 2011/03/03 17:08:14, udono wrote:
> no need

Good catch. Done.

[ced, 2011-03-06 00:54:10]

http://codereview.appspot.com/4237054/diff/3001/tryton/client.py
File tryton/client.py (right):

http://codereview.appspot.com/4237054/diff/3001/tryton/client.py#newcode81
tryton/client.py:81: self.quit_client = threading.Event()
I will instantiate it only if needed.

http://codereview.appspot.com/4237054/diff/3001/tryton/client.py#newcode87
tryton/client.py:87: signal.signal(signal.SIGINT, lambda signum, frame:
self.quit_client.set())
Part of an other patch that call sig_quit

http://codereview.appspot.com/4237054/diff/3001/tryton/gui/main.py
File tryton/gui/main.py (right):

http://codereview.appspot.com/4237054/diff/3001/tryton/gui/main.py#newcode60
tryton/gui/main.py:60: Main.quit_event = quit_event
Class attributes should be define with a default value at class level

http://codereview.appspot.com/4237054/diff/3001/tryton/gui/main.py#newcode1324
tryton/gui/main.py:1324: rpc.logout()
Part of an other patch

http://codereview.appspot.com/4237054/diff/3001/tryton/gui/main.py#newcode1331
tryton/gui/main.py:1331: if sys.platform == 'win32':
I think it is better to check if quit_event is set or not to put the logic of
quit main loop only in client.py

[nicoe, 2011-03-08 09:38:13]

http://codereview.appspot.com/4237054/diff/3001/tryton/client.py
File tryton/client.py (right):

http://codereview.appspot.com/4237054/diff/3001/tryton/client.py#newcode87
tryton/client.py:87: signal.signal(signal.SIGINT, lambda signum, frame:
self.quit_client.set())
On 2011/03/06 00:54:10, ced wrote:
> Part of an other patch that call sig_quit

Not at all. You need this to quit the pseudo main loop we create for windows

http://codereview.appspot.com/4237054/diff/3001/tryton/gui/main.py
File tryton/gui/main.py (right):

http://codereview.appspot.com/4237054/diff/3001/tryton/gui/main.py#newcode1324
tryton/gui/main.py:1324: rpc.logout()
On 2011/03/06 00:54:10, ced wrote:
> Part of an other patch

Done.

http://codereview.appspot.com/4237054/diff/3001/tryton/gui/main.py#newcode1331
tryton/gui/main.py:1331: if sys.platform == 'win32':
On 2011/03/06 00:54:10, ced wrote:
> I think it is better to check if quit_event is set or not to put the logic of
> quit main loop only in client.py

Done.

[ced, 2011-03-08 10:36:24]

http://codereview.appspot.com/4237054/diff/3001/tryton/client.py
File tryton/client.py (right):

http://codereview.appspot.com/4237054/diff/3001/tryton/client.py#newcode87
tryton/client.py:87: signal.signal(signal.SIGINT, lambda signum, frame:
self.quit_client.set())
On 2011/03/08 09:38:14, nicoe wrote:
> On 2011/03/06 00:54:10, ced wrote:
> > Part of an other patch that call sig_quit
> 
> Not at all. You need this to quit the pseudo main loop we create for windows

So need update to trunk

http://codereview.appspot.com/4237054/diff/2003/tryton/gui/main.py
File tryton/gui/main.py (right):

http://codereview.appspot.com/4237054/diff/2003/tryton/gui/main.py#newcode1332
tryton/gui/main.py:1332: if isinstance(cls.quit_event, threading.Event):
Why not just: if cls.quit_event

http://codereview.appspot.com/4237054/diff/2003/tryton/gui/main.py#newcode1332
tryton/gui/main.py:1332: if isinstance(cls.quit_event, threading.Event):
Indeed, I think it is better to put this stopping loop code in client.py and
make quit_event a method.