Issue 4237050: code review 4237050: cgo: put temporary source files in _obj.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4237050: code review 4237050: cgo: put temporary source files in _obj. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by rog

Modified:
14 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cgo: put temporary source files in _obj. Fixes issue 1572. Initially I tried changing things so all object files get put in _obj, but it's too much - everything needs changing. Perhaps some other time.

Patch Set 1 #

Patch Set 2 : diff -r d9ff478c4ed3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d9ff478c4ed3 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -43 lines)			Patch
M	src/Make.pkg	View	1	7 chunks	+24 lines, -24 lines	0 comments	Download
M	src/cmd/cgo/gcc.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/cgo/main.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/cgo/out.go	View	1	5 chunks	+9 lines, -18 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-03-02 19:12:21 UTC) #1

rsc

14 years ago (2011-03-02 19:22:37 UTC) #3

*** Submitted as 9f4e8ac75c45 ***

cgo: put temporary source files in _obj.
Fixes issue 1572.
Initially I tried changing things so all object
files get put in _obj, but it's too much - everything
needs changing. Perhaps some other time.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4237050

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages