Issue 4235043: code review 4235043: runtime: omit breakpoint during terminal panic

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4235043: code review 4235043: runtime: omit breakpoint during terminal panic (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by rsc

Modified:
14 years ago

Reviewers:
brainman

CC:
r, r2, golang-dev

Visibility:
Public.

runtime: omit breakpoint during terminal panic again. CL 4222043 missed this case.

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	src/pkg/runtime/runtime.c	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4

rsc

Hello brainman, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-02-25 15:10:28 UTC) #1

rsc

*** Submitted as 6f62f82800c6 *** runtime: omit breakpoint during terminal panic again. CL 4222043 missed ...

14 years ago (2011-02-25 20:17:38 UTC) #3

LGTM. Thank you, Russ.