Issue 4223049: code review 4223049: runtime: add empty windows/signals.h file to fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4223049: code review 4223049: runtime: add empty windows/signals.h file to fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by brainman

Modified:
14 years ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

runtime: add empty windows/signals.h file to fix build

Patch Set 2 : diff -r 0d7c59b3e418 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0d7c59b3e418 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 0d7c59b3e418 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 0d7c59b3e418 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	A	src/pkg/runtime/windows/signals.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-02-24 23:37:12 UTC) #1

gri

LGTM http://codereview.appspot.com/4223049/diff/2003/src/pkg/runtime/windows/signals.h File src/pkg/runtime/windows/signals.h (right): http://codereview.appspot.com/4223049/diff/2003/src/pkg/runtime/windows/signals.h#newcode1 src/pkg/runtime/windows/signals.h:1: // Copyright 2009 The Go Authors. All rights ...

14 years ago (2011-02-25 00:03:32 UTC) #2

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=2cc3fdd297ee *** runtime: add empty windows/signals.h file to fix build R=golang-dev, gri ...

14 years ago (2011-02-25 00:16:48 UTC) #3

On 2011/02/25 00:03:32, gri wrote:
> LGTM

Thank you.

Expand All Messages | Collapse All Messages