code review 4221046: reflect: add pointer word to CommonType

reflect: add pointer word to CommonType

The pointer will eventually let us find *T given T.
This CL just makes room for it, always storing a zero.

[rsc, 2011-02-24 05:49:58]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-02-24 06:11:45]

http://codereview.appspot.com/4221046/diff/4006/src/cmd/gc/reflect.c
File src/cmd/gc/reflect.c (right):

http://codereview.appspot.com/4221046/diff/4006/src/cmd/gc/reflect.c#newcode596
src/cmd/gc/reflect.c:596: //		ptr *Type
wrong name, plus please add a reference to commentary

http://codereview.appspot.com/4221046/diff/4006/src/pkg/reflect/type.go
File src/pkg/reflect/type.go (right):

http://codereview.appspot.com/4221046/diff/4006/src/pkg/reflect/type.go#newco...
src/pkg/reflect/type.go:51: ptrto *runtime.Type
ptrToThis

also it would be good to refer to runtime/type.go or maybe even copy the
comments

http://codereview.appspot.com/4221046/diff/4006/src/pkg/runtime/type.go
File src/pkg/runtime/type.go (right):

http://codereview.appspot.com/4221046/diff/4006/src/pkg/runtime/type.go#newco...
src/pkg/runtime/type.go:38: ptrto         *Type   // pointer to this type, if
used in binary or has methods
i'd prefer ptrTo or, even better, ptrToThis.   i thought of that name before i
read the comment, so you should agree.

[rsc1, 2011-02-24 21:51:41]

PTAL

http://codereview.appspot.com/4221046/diff/4006/src/cmd/gc/reflect.c
File src/cmd/gc/reflect.c (right):

http://codereview.appspot.com/4221046/diff/4006/src/cmd/gc/reflect.c#newcode596
src/cmd/gc/reflect.c:596: //		ptr *Type
On 2011/02/24 06:11:45, r wrote:
> wrong name, plus please add a reference to commentary

changed name.  commentary reference is on 585.

http://codereview.appspot.com/4221046/diff/4006/src/pkg/reflect/type.go
File src/pkg/reflect/type.go (right):

http://codereview.appspot.com/4221046/diff/4006/src/pkg/reflect/type.go#newco...
src/pkg/reflect/type.go:51: ptrto *runtime.Type
On 2011/02/24 06:11:45, r wrote:
> ptrToThis
> 
> also it would be good to refer to runtime/type.go or maybe even copy the
> comments

changed name; reference is on 25

http://codereview.appspot.com/4221046/diff/4006/src/pkg/runtime/type.go
File src/pkg/runtime/type.go (right):

http://codereview.appspot.com/4221046/diff/4006/src/pkg/runtime/type.go#newco...
src/pkg/runtime/type.go:38: ptrto         *Type   // pointer to this type, if
used in binary or has methods
On 2011/02/24 06:11:45, r wrote:
> i'd prefer ptrTo or, even better, ptrToThis.   i thought of that name before i
> read the comment, so you should agree.

Done.

[r2, 2011-02-24 21:56:31]

LGTM

[rsc, 2011-02-24 22:11:22]

*** Submitted as http://code.google.com/p/go/source/detail?r=06b81b9faf7a ***

reflect: add pointer word to CommonType

The pointer will eventually let us find *T given T.
This CL just makes room for it, always storing a zero.

R=r, r2
CC=golang-dev
http://codereview.appspot.com/4221046