Avoid over-compilation by runtime JS compiler

2 lessons on quoting requirement on parameters:
- if they are user facing, incl. query params.
  ie: getUrlParameters().forcesecure.
- if they don't follow namespace defined in <exports>.
  ie: targetEl.gadgets.rpc.

Respectively, this results in:
- Invalid auth token. X vs Y
- Same domain call failed: parent= incorrectly set

[johnfargo, 2011-02-24 22:59:29]

Makes total sense to me. Please update the patch to reflect latest state though
-- looks like it's out of date.

[mhermanto, 2011-02-24 23:12:59]

Done (updated). Also, added more changes that are affected by
getUrlParameters(). PTAL.

On Thu, Feb 24, 2011 at 2:59 PM, <johnfargo@gmail.com> wrote:

> Makes total sense to me. Please update the patch to reflect latest state
> though -- looks like it's out of date.
>
>
> http://codereview.appspot.com/4220047/
>

[fargo, 2011-02-24 23:13:21]

We probably have overlap, but that's all good in the hood.

On Thu, Feb 24, 2011 at 3:12 PM, Michael Hermanto <mhermanto@gmail.com>wrote:

> Done (updated). Also, added more changes that are affected by
> getUrlParameters(). PTAL.
>
>
> On Thu, Feb 24, 2011 at 2:59 PM, <johnfargo@gmail.com> wrote:
>
>> Makes total sense to me. Please update the patch to reflect latest state
>> though -- looks like it's out of date.
>>
>>
>> http://codereview.appspot.com/4220047/
>>
>
>

[johnfargo, 2011-02-24 23:14:29]

LGTM++

Check out mine for a few others:
http://codereview.appspot.com/4220048/

On 2011/02/24 23:13:21, fargo wrote:
> We probably have overlap, but that's all good in the hood.
> 
> On Thu, Feb 24, 2011 at 3:12 PM, Michael Hermanto <mhermanto@gmail.com>wrote:
> 
> > Done (updated). Also, added more changes that are affected by
> > getUrlParameters(). PTAL.
> >
> >
> > On Thu, Feb 24, 2011 at 2:59 PM, <mailto:johnfargo@gmail.com> wrote:
> >
> >> Makes total sense to me. Please update the patch to reflect latest state
> >> though -- looks like it's out of date.
> >>
> >>
> >> http://codereview.appspot.com/4220047/
> >>
> >
> >

[mhermanto, 2011-02-24 23:17:54]

On Thu, Feb 24, 2011 at 3:14 PM, <johnfargo@gmail.com> wrote:

> LGTM++
>
> Check out mine for a few others:
> http://codereview.appspot.com/4220048/


Whoah, ok, I'll patch yours into mine and I'll submit them together.

>
>
> On 2011/02/24 23:13:21, fargo wrote:
>
>> We probably have overlap, but that's all good in the hood.
>>
>
>  On Thu, Feb 24, 2011 at 3:12 PM, Michael Hermanto
>>
> <mhermanto@gmail.com>wrote:
>
>  > Done (updated). Also, added more changes that are affected by
>> > getUrlParameters(). PTAL.
>> >
>> >
>> > On Thu, Feb 24, 2011 at 2:59 PM, <mailto:johnfargo@gmail.com> wrote:
>> >
>> >> Makes total sense to me. Please update the patch to reflect latest
>>
> state
>
>> >> though -- looks like it's out of date.
>> >>
>> >>
>> >> http://codereview.appspot.com/4220047/
>> >>
>> >
>> >
>>
>
>
>
> http://codereview.appspot.com/4220047/
>