Issue 4218042: code review 4218042: xml: fix typo in test.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4218042: code review 4218042: xml: fix typo in test. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by mattn

Modified:
14 years ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

xml: fix typo in test.

Patch Set 1 #

Patch Set 2 : diff -r 726656100924 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 726656100924 http://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	src/pkg/xml/read_test.go	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mattn

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg/

14 years ago (2011-02-24 06:19:17 UTC) #1

rsc

LGTM i suppose. very hard to get excited about calling rss atom in a test ...

14 years ago (2011-03-02 20:05:38 UTC) #2

LGTM

i suppose.  very hard to get excited about calling rss atom in a test file.


On Thu, Feb 24, 2011 at 01:19,  <mattn.jp@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> http://go.googlecode.com/hg/
>
>
> Description:
> xml: fix typo in test.
>
> Please review this at http://codereview.appspot.com/4218042/
>
> Affected files:
>  M src/pkg/xml/read_test.go
>
>
> Index: src/pkg/xml/read_test.go
> ===================================================================
> --- a/src/pkg/xml/read_test.go
> +++ b/src/pkg/xml/read_test.go
> @@ -13,16 +13,16 @@
>
>  func TestUnmarshalFeed(t *testing.T) {
>        var f Feed
> -       if err := Unmarshal(StringReader(rssFeedString), &f); err != nil {
> +       if err := Unmarshal(StringReader(atomFeedString), &f); err != nil {
>                t.Fatalf("Unmarshal: %s", err)
>        }
> -       if !reflect.DeepEqual(f, rssFeed) {
> -               t.Fatalf("have %#v\nwant %#v", f, rssFeed)
> +       if !reflect.DeepEqual(f, atomFeed) {
> +               t.Fatalf("have %#v\nwant %#v", f, atomFeed)
>        }
>  }
>
>  // hget http://codereview.appspot.com/rss/mine/rsc
> -const rssFeedString = `
> +const atomFeedString = `
>  <?xml version="1.0" encoding="utf-8"?>
>  <feed xmlns="http://www.w3.org/2005/Atom" xml:lang="en-us"><title>Code
> Review - My issues</title><link href="http://codereview.appspot.com/"
> rel="alternate"></link><li-nk
> href="http://codereview.appspot.com/rss/mine/rsc"
>
rel="self"></li-nk><id>http://codereview.appspot.com/</id><updated>2009-10-04T01:35:58+00:00</updated><author><name>rietveld&lt;&gt;</name></author><entry><title>rietveld:
> an attempt at pubsubhubbub
>  </title><link hre-f="http://codereview.appspot.com/126085"
>
rel="alternate"></link><updated>2009-10-04T01:35:58+00:00</updated><author><name>email-address-removed</name></author><id>urn:md5:134d9179c41f806be79b3a5f7877d19a</id><summary
> type="html">
> @@ -115,7 +115,7 @@
>
>  type Time string
>
> -var rssFeed = Feed{
> +var atomFeed = Feed{
>        XMLName: Name{"http://www.w3.org/2005/Atom", "feed"},
>        Title:   "Code Review - My issues",
>        Link: []Link{
>
>
>

rsc

14 years ago (2011-03-02 20:05:54 UTC) #3

*** Submitted as 82c6c5eb84fb ***

xml: fix typo in test.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4218042

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages