Issue 4213044: code review 4213044: release.2011-02-24

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4213044: code review 4213044: release.2011-02-24 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by adg

Modified:
13 years, 5 months ago

Reviewers:
rog

CC:
r, rsc, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r 9c3f4b89fcff https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -1 line)			Patch
	M	.hgtags	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	doc/devel/release.html	View	1	1 chunk	+83 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello r, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-02-25 02:43:17 UTC) #1

rsc1

LGTM http://codereview.appspot.com/4213044/diff/1/doc/devel/release.html File doc/devel/release.html (right): http://codereview.appspot.com/4213044/diff/1/doc/devel/release.html#newcode39 doc/devel/release.html:39: 6l: new -Hwindowsgui flag allows to build windows ...

13 years, 5 months ago (2011-02-25 03:05:29 UTC) #2

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=322350d6fdbf *** release.2011-02-24 R=r, rsc CC=golang-dev http://codereview.appspot.com/4213044

13 years, 5 months ago (2011-02-25 03:13:22 UTC) #3

rog

13 years, 5 months ago (2011-02-25 10:28:04 UTC) #4

On 25 February 2011 02:43,  <adg@golang.org> wrote:
> +* netchan: allow use of arbitrary connections (thanks Roger Peppe).

it might be worth adding a note to the release saying that
this caused the netchan API to undergo significant change,
and any program using netchan will need to be adapted
accordingly.

Expand All Messages | Collapse All Messages