Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(658)

Issue 4213044: code review 4213044: release.2011-02-24 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by adg
Modified:
11 years, 9 months ago
Reviewers:
rog
CC:
r, rsc, golang-dev
Visibility:
Public.

Description

release.2011-02-24

Patch Set 1 #

Total comments: 5

Patch Set 2 : diff -r 9c3f4b89fcff https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/release.html View 1 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 4
adg
Hello r, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 9 months ago (2011-02-25 02:43:17 UTC) #1
rsc1
LGTM http://codereview.appspot.com/4213044/diff/1/doc/devel/release.html File doc/devel/release.html (right): http://codereview.appspot.com/4213044/diff/1/doc/devel/release.html#newcode39 doc/devel/release.html:39: 6l: new -Hwindowsgui flag allows to build windows ...
11 years, 9 months ago (2011-02-25 03:05:29 UTC) #2
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=322350d6fdbf *** release.2011-02-24 R=r, rsc CC=golang-dev http://codereview.appspot.com/4213044
11 years, 9 months ago (2011-02-25 03:13:22 UTC) #3
rog
11 years, 9 months ago (2011-02-25 10:28:04 UTC) #4
On 25 February 2011 02:43,  <adg@golang.org> wrote:
> +* netchan: allow use of arbitrary connections (thanks Roger Peppe).

it might be worth adding a note to the release saying that
this caused the netchan API to undergo significant change,
and any program using netchan will need to be adapted
accordingly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b