code review 4213044: release.2011-02-24

release.2011-02-24

[adg, 2011-02-25 02:43:17]

Hello r, rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc1, 2011-02-25 03:05:29]

LGTM

http://codereview.appspot.com/4213044/diff/1/doc/devel/release.html
File doc/devel/release.html (right):

http://codereview.appspot.com/4213044/diff/1/doc/devel/release.html#newcode39
doc/devel/release.html:39: 6l: new -Hwindowsgui flag allows to build windows gui
pe (thanks Alex Brainman).
strange indent, move up with 37

http://codereview.appspot.com/4213044/diff/1/doc/devel/release.html#newcode45
doc/devel/release.html:45: * compress: restructure to share testdata with all
compression algorithms.
really?  i thought that happened long ago

http://codereview.appspot.com/4213044/diff/1/doc/devel/release.html#newcode58
doc/devel/release.html:58: add robots.txt, log errors when reading filter files.
some lines missing indents.
this one and line 63

http://codereview.appspot.com/4213044/diff/1/doc/devel/release.html#newcode70
doc/devel/release.html:70: * net: *netFD.Read to return os.EOF on eof (thanks
Alex Brainman),
this was a windows only change
stick windows somewhere in the line

http://codereview.appspot.com/4213044/diff/1/doc/devel/release.html#newcode80
doc/devel/release.html:80: * runtime: always run stackalloc on scheduler stack,
runtime: various bug fixes, more complete stack traces,
    record $GOROOT_FINAL for runtime.GOROOT

[adg, 2011-02-25 03:13:22]

*** Submitted as http://code.google.com/p/go/source/detail?r=322350d6fdbf ***

release.2011-02-24

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/4213044

[rog, 2011-02-25 10:28:04]

On 25 February 2011 02:43,  <adg@golang.org> wrote:
> +* netchan: allow use of arbitrary connections (thanks Roger Peppe).

it might be worth adding a note to the release saying that
this caused the netchan API to undergo significant change,
and any program using netchan will need to be adapted
accordingly.