Issue 42043: Corrections and suggestions to the caja slidedeck

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 42043: Corrections and suggestions to the caja slidedeck (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 11 months ago by Jasvir

Modified:
16 years, 8 months ago

Reviewers:
MarkM

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

* defensively corrects an offensive substitution mistake * adds slides to the list of demos @3474

Patch Set 1 #

Total comments: 2

Created: 16 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -43 lines)			Patch
	M	build.xml	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/com/google/caja/demos/slides/index.html	View		3 chunks	+64 lines, -42 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

MarkM

16 years, 11 months ago (2009-04-16 16:02:17 UTC) #2

Other than these, LGTM.

http://codereview.appspot.com/42043/diff/1/2
File src/com/google/caja/demos/slides/index.html (right):

http://codereview.appspot.com/42043/diff/1/2#newcode657
Line 657: <li>Complicated coercing rules surrounding <tt>==</tt> and
<tt>!=</tt></li>
Oops. This is no longer true. Since we need to support == and != in Valija, it
seemed simplest just to add these back into Cajita. Perhaps we should issue a
warning, but we don't.

http://codereview.appspot.com/42043/diff/1/2#newcode701
Line 701: <li>Defensive Code Problem &#10003;</li>
Shouldn't this have a strikeout?

Expand All Messages | Collapse All Messages