Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(343)

Issue 41950044: Remove the ban on 'command' that are declared in included .isolate file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by M-A
Modified:
11 years, 10 months ago
Reviewers:
kbr1, vadimsh
CC:
swarming-eng_googlegroups.com, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org, rch, ganetsky
Base URL:
https://code.google.com/p/swarming.client@master
Visibility:
Public.

Description

Remove the ban on 'command' that are declared in included .isolate file. Update the unit test to test the case where the command is overriden or not. R=vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=client&r=f89de35

Patch Set 1 #

Total comments: 3

Patch Set 2 : Change precedence. #

Patch Set 3 : even better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -4 lines) Patch
M isolate.py View 1 2 3 chunks +10 lines, -4 lines 0 comments Download
M tests/isolate_test.py View 1 2 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 6
M-A
This is a problem when importing chrome.isolate from another other .isolate since it defines a ...
11 years, 10 months ago (2013-12-13 20:58:40 UTC) #1
vadimsh
https://codereview.appspot.com/41950044/diff/1/tests/isolate_test.py File tests/isolate_test.py (right): https://codereview.appspot.com/41950044/diff/1/tests/isolate_test.py#newcode835 tests/isolate_test.py:835: # Falls back to isolate1 'command' and not 'isolate2'. ...
11 years, 10 months ago (2013-12-13 21:10:33 UTC) #2
M-A
https://codereview.appspot.com/41950044/diff/1/tests/isolate_test.py File tests/isolate_test.py (right): https://codereview.appspot.com/41950044/diff/1/tests/isolate_test.py#newcode835 tests/isolate_test.py:835: # Falls back to isolate1 'command' and not 'isolate2'. ...
11 years, 10 months ago (2013-12-13 21:30:15 UTC) #3
vadimsh
lgtm
11 years, 10 months ago (2013-12-13 21:43:48 UTC) #4
kbr1
Thanks for implementing this! I had been pretty confused why the include didn't work.
11 years, 10 months ago (2013-12-13 22:00:17 UTC) #5
M-A
11 years, 10 months ago (2013-12-13 22:06:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as rf89de35 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b