Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 4188063: code review 4188063: godoc: serve robots.txt raw (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by adg
Modified:
10 years ago
Reviewers:
CC:
gri, niemeyer, rsc, r2, r, golang-dev
Visibility:
Public.

Description

godoc: serve robots.txt raw

Patch Set 1 #

Patch Set 2 : diff -r 440678ea208a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 440678ea208a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 5470a0d5f7a9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A robots.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/godoc/godoc.go View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9
adg
Hello gri, n13m3y3r@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years ago (2011-02-18 17:57:26 UTC) #1
adg
Thoughts on including a robots.txt in this CL containing User-agent: * Disallow: / ? An ...
10 years ago (2011-02-18 18:15:34 UTC) #2
rsc
> An alternative: programatically generating it from inside godoc with a > custom http Handler. ...
10 years ago (2011-02-18 18:27:56 UTC) #3
r2
i would vote for option 2, but my opinion carries little weight in matters of ...
10 years ago (2011-02-18 18:28:03 UTC) #4
r
there you go. -rob
10 years ago (2011-02-18 18:28:47 UTC) #5
rsc
LGTM
10 years ago (2011-02-18 18:30:54 UTC) #6
adg
PTAL I've added a robots.txt. On 18 February 2011 10:26, Russ Cox <rsc@golang.org> wrote: > ...
10 years ago (2011-02-18 18:35:22 UTC) #7
rsc
LGTM
10 years ago (2011-02-18 18:39:53 UTC) #8
adg
10 years ago (2011-02-18 18:46:24 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=1dce856140eb ***

godoc: serve robots.txt raw

R=gri, niemeyer, rsc, r2, r
CC=golang-dev
http://codereview.appspot.com/4188063
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b