Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(362)

Issue 4187052: Pull up tamings___ to global namespace. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by mhermanto
Modified:
15 years ago
Reviewers:
johnfargo, Jasvir, fargo
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

JS runtime compilation is not happy when variable "tamings___" is declared multiple times, one in each feature.

Patch Set 1 : Update patch #

Patch Set 2 : Update patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -28 lines) Patch
extras/src/main/javascript/features-extras/pubsub-2/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
extras/src/main/javascript/features-extras/pubsub-2/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
extras/src/main/javascript/features-extras/wave/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
extras/src/main/javascript/features-extras/wave/taming.js View 1 1 chunk +0 lines, -3 lines 0 comments Download
features/src/main/javascript/features/caja/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/caja/taming.js View 1 2 chunks +1 line, -2 lines 0 comments Download
features/src/main/javascript/features/com.google.gadgets.analytics/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/com.google.gadgets.analytics/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/core.io/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/core.io/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/core.json/feature.xml View 1 2 chunks +1 line, -1 line 0 comments Download
features/src/main/javascript/features/core.json/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/core.log/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/core.log/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/core.prefs/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/core.prefs/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/core.util/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/core.util/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/dynamic-height/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/dynamic-height/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/flash/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/flash/taming.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
features/src/main/javascript/features/minimessage/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/minimessage/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/opensocial-data-context/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/opensocial-data-context/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/opensocial-reference/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/opensocial-reference/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/osapi/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/osapi/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/pubsub/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/pubsub/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/settitle/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/settitle/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/skins/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/skins/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/tabs/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/tabs/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download
features/src/main/javascript/features/taming/taming.js View 1 1 chunk +15 lines, -3 lines 0 comments Download
features/src/main/javascript/features/views/feature.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/views/taming.js View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5
mhermanto
15 years ago (2011-02-17 23:52:39 UTC) #1
Jasvir
LGTM Should other features all depend on global?
15 years ago (2011-02-18 22:08:26 UTC) #2
mhermanto
Update patch
15 years ago (2011-02-19 02:23:38 UTC) #3
mhermanto
It turns out that we'd need more tamings/caja globals declared. To avoid polluting namespace for ...
15 years ago (2011-02-19 02:26:11 UTC) #4
johnfargo
15 years ago (2011-02-23 00:34:55 UTC) #5
LGTM

The downside of putting tamings into its own feature is that the <dependency>
ends up in quite a few more places. But it is more descriptive, so seems ok..

On 2011/02/19 02:26:11, mhermanto wrote:
> It turns out that we'd need more tamings/caja globals declared. To avoid
> polluting namespace for all features (depending on globals), I've created
> feature=taming, and have only tamed features (ie: features with taming.js)
> depend on it. This is more verbose, but more focussed. PTAL.
> 
> On Fri, Feb 18, 2011 at 6:23 PM, <mailto:mhermanto@gmail.com> wrote:
> 
> > Update patch
> >
> >
> > http://codereview.appspot.com/4187052/
> >
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b