code review 4185053: http: introduce Header type, implement with net/textproto

src/pkg/http/serve_test.go

 // Copyright 2010 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // End-to-end serving tests
 
 package http
 
 import (
         "bufio"
@@ skipping 179 matching lines @@
                 }
                 if err := cc.Write(&req); err != nil {
                         t.Errorf("writing request: %v", err)
                         continue
                 }
                 r, err := cc.Read(&req)
                 if err != nil {
                         t.Errorf("reading response: %v", err)
                         continue
                 }
-                s_, ok := r.Header["Result"]

[rsc, 2011/02/22 21:53:44]

s := r.Header.Get("Result")

[petar-m, 2011/02/22 23:18:44]

Done.

-                if !ok || s_[0] != vt.expected {
-                        t.Errorf("Get(%q) = %q, want %q", vt.url, s_[0], vt.expected)

[mattn, 2011/02/18 13:26:57]

if ok is false, s_ will be nil. Then it will be panic.

[petar-m, 2011/02/22 23:18:44]

Done.

+                s := r.Header.Get("Result")
+                if s != vt.expected {
+                        t.Errorf("Get(%q) = %q, want %q", vt.url, s, vt.expected)
                 }
         }
 }
 
 type responseWriterMethodCall struct {
         method                 string
         headerKey, headerValue string // if method == "SetHeader"
         bytesWritten           []byte // if method == "Write"
         responseCode           int    // if method == "WriteHeader"
 }
@@ skipping 129 matching lines @@
                 t.Fatalf("http Get #2: %v", err)
         }
         got, _ = ioutil.ReadAll(r.Body)
         expected = "req=2"
         if string(got) != expected {
                 t.Errorf("Get #2 got %q, want %q", string(got), expected)
         }
 
         l.Close()
 }