code review 4185053: http: introduce Header type, implement with net/textproto

src/pkg/http/fs.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // HTTP file system request handler
 
 package http
 
 import (
         "fmt"
@@ skipping 86 matching lines @@
                                 return
                         }
                 } else {
                         if url[len(url)-1] == '/' {
                                 Redirect(w, r, url[0:len(url)-1], StatusMovedPermanently)
                                 return
                         }
                 }
         }
 
-        if t, _ := time.Parse(TimeFormat, r.Header["If-Modified-Since"]); t != nil && d.Mtime_ns/1e9 <= t.Seconds() {
+        if t, _ := time.Parse(TimeFormat, r.Header.Get("If-Modified-Since")); t != nil && d.Mtime_ns/1e9 <= t.Seconds() {
                 w.WriteHeader(StatusNotModified)
                 return
         }
         w.SetHeader("Last-Modified", time.SecondsToUTC(d.Mtime_ns/1e9).Format(TimeFormat))
 
         // use contents of index.html for directory, if present
         if d.IsDirectory() {
                 index := name + indexPage
                 ff, err := os.Open(index, os.O_RDONLY, 0)
                 if err == nil {
@@ skipping 28 matching lines @@
                 if isText(b) {
                         w.SetHeader("Content-Type", "text-plain; charset=utf-8")
                 } else {
                         w.SetHeader("Content-Type", "application/octet-stream") // generic binary
                 }
                 f.Seek(0, 0) // rewind to output whole file
         }
 
         // handle Content-Range header.
         // TODO(adg): handle multiple ranges
-        ranges, err := parseRange(r.Header["Range"], size)
+        ranges, err := parseRange(r.Header.Get("Range"), size)
         if err != nil || len(ranges) > 1 {
                 Error(w, err.String(), StatusRequestedRangeNotSatisfiable)
                 return
         }
         if len(ranges) == 1 {
                 ra := ranges[0]
                 if _, err := f.Seek(ra.start, 0); err != nil {
                         Error(w, err.String(), StatusRequestedRangeNotSatisfiable)
                         return
                 }
@@ skipping 89 matching lines @@
                                 if i >= size {
                                         i = size - 1
                                 }
                                 r.length = i - r.start + 1
                         }
                 }
                 ranges = append(ranges, r)
         }
         return ranges, nil
 }