Issue 4184051: code review 4184051: net: fix windows build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4184051: code review 4184051: net: fix windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by brainman

Modified:
14 years ago

Reviewers:

CC:
golang-dev, r2

Visibility:
Public.

Description

net: fix windows build

Patch Set 1 #

Patch Set 2 : diff -r 4892f94182a5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4892f94182a5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 40f3009e211f https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
	M	src/pkg/net/multicast_test.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/pkg/syscall/syscall_windows.go	View	1	1 chunk	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-02-16 23:33:56 UTC) #1

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=e8ae44f3e5de *** net: fix windows build R=golang-dev, r2 CC=golang-dev http://codereview.appspot.com/4184051

14 years ago (2011-02-17 01:00:10 UTC) #3

On 2011/02/17 00:32:51, r2 wrote:
> LGTM
> 

Thank you for review.

Expand All Messages | Collapse All Messages