Issue 4182053: JS loader now executes a callback (if globally specified).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4182053: JS loader now executes a callback (if globally specified). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by mhermanto

Modified:
15 years ago

Reviewers:
johnfargo

CC:
dev-remailer_shindig.apache.org

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

This is specified by a feature=jsloader JS that is not in Shindig yet.

Patch Set 1 #

Total comments: 1

Created: 15 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+119 lines, -3 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJsLoadCallbackProcessor.java	View	1 chunk	+45 lines, -0 lines	1 comment	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/InjectJsInfoVariableProcessor.java	View	1 chunk	+5 lines, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JavascriptModule.java	View	1 chunk	+4 lines, -2 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/AddJsLoadCallbackProcessorTest.java	View	1 chunk	+65 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

johnfargo

http://codereview.appspot.com/4182053/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJsLoadCallbackProcessor.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJsLoadCallbackProcessor.java (right): http://codereview.appspot.com/4182053/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJsLoadCallbackProcessor.java#newcode30 java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJsLoadCallbackProcessor.java:30: "if(j['c']&&--j['o']<=0){"+ don't you want >= 0?

15 years ago (2011-02-24 22:55:52 UTC) #2

johnfargo

15 years ago (2011-02-24 22:56:33 UTC) #3

LGTM

NM, you don't.

On Thu, Feb 24, 2011 at 2:55 PM, <johnfargo@gmail.com> wrote:

>
>
>
http://codereview.appspot.com/4182053/diff/1/java/gadgets/src/main/java/org/a...
> File
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJsLoadCallbackProcessor.java
> (right):
>
>
>
http://codereview.appspot.com/4182053/diff/1/java/gadgets/src/main/java/org/a...
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJsLoadCallbackProcessor.java:30:
> "if(j['c']&&--j['o']<=0){"+
> don't you want >= 0?
>
> http://codereview.appspot.com/4182053/
>

Expand All Messages | Collapse All Messages